Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show imported value initially in MUI autocomplete inputs #1065

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

dalen
Copy link
Contributor

@dalen dalen commented Jun 17, 2024

When importing a query from for example json logic, show the imported value initially in autocomplete inputs that use an asyncFetch. Before this they would show no value at all until you clicked on them and they loaded all the options.

Copy link

codesandbox bot commented Jun 17, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-awesome-query-builder-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 4:56pm
react-awesome-query-builder-sandbox 🛑 Canceled (Inspect) Jun 19, 2024 4:56pm
react-awesome-query-builder-sandbox-next ✅ Ready (Inspect) Visit Preview Jun 19, 2024 4:56pm

Copy link

codesandbox-ci bot commented Jun 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 34557bd:

Sandbox Source
@react-awesome-query-builder/examples Configuration
@react-awesome-query-builder/sandbox Configuration
@react-awesome-query-builder/sandbox-simple Configuration
@react-awesome-query-builder/sandbox-next Configuration

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.04%. Comparing base (d4690b1) to head (34557bd).

Files Patch % Lines
...ages/mui/modules/widgets/value/MuiAutocomplete.jsx 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
- Coverage   82.05%   82.04%   -0.01%     
==========================================
  Files         211      211              
  Lines       10969    10969              
  Branches     1328     1328              
==========================================
- Hits         9001     9000       -1     
  Misses       1355     1355              
- Partials      613      614       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dalen and others added 2 commits June 19, 2024 19:50
When importing a query from for example json logic, show the imported value initially in autocomplete inputs that use an asyncFetch. Before this they would show no value at all until you clicked on them and they loaded all the options.
@ukrbublik
Copy link
Owner

Thanks for the PR!
I had to add a fix for a case when autocomplete value is empty, like when you add new rule with autocomplete field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants