Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getOptionLabel always return a string #1064

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

dalen
Copy link
Contributor

@dalen dalen commented Jun 17, 2024

MUI expects the label to always be a string, even if the option value is a number. Failing to provide a string gives the warning:

MUI: The `getOptionLabel` method of Autocomplete returned number(x) instead of a string for x.

MUI expects the label to always be a string, even if the option value is a number. Failing to provide a string gives the warning:

MUI: The `getOptionLabel` method of Autocomplete returned number(x) instead of a string for x.
Copy link

codesandbox bot commented Jun 17, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-awesome-query-builder-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 10:43am
react-awesome-query-builder-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 10:43am
react-awesome-query-builder-sandbox-next ✅ Ready (Inspect) Visit Preview Jun 17, 2024 10:43am

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4cfa47a:

Sandbox Source
@react-awesome-query-builder/examples Configuration
@react-awesome-query-builder/sandbox Configuration
@react-awesome-query-builder/sandbox-simple Configuration
@react-awesome-query-builder/sandbox-next Configuration

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.07%. Comparing base (2310dd2) to head (4cfa47a).

Files Patch % Lines
...ges/ui/modules/hooks/useListValuesAutocomplete.jsx 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1064   +/-   ##
=======================================
  Coverage   82.07%   82.07%           
=======================================
  Files         211      211           
  Lines       10844    10844           
  Branches     1316     1316           
=======================================
  Hits         8900     8900           
  Misses       1341     1341           
  Partials      603      603           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ukrbublik ukrbublik merged commit d4690b1 into ukrbublik:master Jun 19, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants