Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JsonLogic Export for SwitchCase #1013

Merged

Conversation

aepfli
Copy link
Contributor

@aepfli aepfli commented Dec 4, 2023

Adding a simple approach for JsonLogic export for switch case. This should allow future adaption of also imports etc.

Note: this is a first draft, to verify if this approach is actually the right one, and to get better insight. I do plan to do the importing part at a later stage too

Ps: sorry my linter went havoc, i will remove the unnecessary formatting changes at a later stage

Copy link

codesandbox bot commented Dec 4, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-awesome-query-builder-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 11:28pm
react-awesome-query-builder-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 11:28pm
react-awesome-query-builder-sandbox-next ✅ Ready (Inspect) Visit Preview May 22, 2024 11:28pm

aepfli and others added 2 commits May 22, 2024 23:47
Adding a simple approach for JsonLogic export for switch case.
This should allow future adaption of also imports etc.

Signed-off-by: Simon Schrottner <[email protected]>
fix

.
@ukrbublik ukrbublik force-pushed the feat/Add_JSON_Logic_export_for_switch_case branch from c2b188c to 745ac21 Compare May 22, 2024 22:58
@ukrbublik
Copy link
Owner

Thank you for the interest in this feature!
Sorry I was not able to review the PR earlier

@ukrbublik ukrbublik self-requested a review May 22, 2024 22:59
Copy link

codesandbox-ci bot commented May 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e4dab51:

Sandbox Source
@react-awesome-query-builder/examples Configuration
@react-awesome-query-builder/sandbox Configuration
@react-awesome-query-builder/sandbox-simple Configuration
@react-awesome-query-builder/sandbox-next Configuration

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 70.31250% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 81.90%. Comparing base (40f3b1b) to head (e4dab51).

Files Patch % Lines
packages/core/modules/export/jsonLogic.js 75.43% 14 Missing ⚠️
packages/core/modules/utils/export.js 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
- Coverage   81.97%   81.90%   -0.08%     
==========================================
  Files         211      211              
  Lines       10577    10637      +60     
  Branches     1318     1318              
==========================================
+ Hits         8671     8712      +41     
- Misses       1293     1312      +19     
  Partials      613      613              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ukrbublik ukrbublik merged commit f8db3b8 into ukrbublik:master May 22, 2024
12 of 14 checks passed
@ukrbublik ukrbublik added this to the Ternary milestone Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants