Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spel import does not accept negative number field values #1055

Closed
sebakerckhof opened this issue May 27, 2024 · 0 comments · Fixed by #1054
Closed

Spel import does not accept negative number field values #1055

sebakerckhof opened this issue May 27, 2024 · 0 comments · Fixed by #1054

Comments

@sebakerckhof
Copy link

Describe the bug
I can't seem to import a spel expression for a numeric field with a negtive value

To Reproduce

  1. Go to https://ukrbublik.github.io/react-awesome-query-builder/
  2. Enter num == -1 in the spel import field
  3. Press import

Expected behavior
Import should work and parse to:
image

Screenshots
image

Additional context
It is possible to set negative numbers when manually defining the rules, on export it also works, but import fails
ukrbublik added a commit that referenced this issue May 31, 2024
@ukrbublik
fix issue with negative spel #1055
7c8bab1
@ukrbublik ukrbublik mentioned this issue Jun 4, 2024
Merged
@ukrbublik ukrbublik linked a pull request Jun 4, 2024 that will close this issue
Render optimizations #1054
Merged
ukrbublik added a commit that referenced this issue Jun 7, 2024
@ukrbublik
Render optimizations (#1054)
52ac610 
* Optimize render of MuiConjs

* show benchmark in example app

* reuse config extended from memo

* remove internal render optimizations

* use callback, memo

* antd Slider FC

* remove optimizeRenderWithInternals

* .

* fix test

* merge type config to field config @ extend

* fix issue #1056

* fix tests

* fix issue with negative spel #1055

* test spil minus

* chlog

* cache

* fix import of negative number as func arg

* memo

* fix tests

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Render optimizations ukrbublik/react-awesome-query-builder
1 participant
@sebakerckhof