Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UAS: Multiple update channels (master, beta, develop) #120

Closed
fuzeman opened this issue Jan 18, 2016 · 19 comments
Closed

UAS: Multiple update channels (master, beta, develop) #120

fuzeman opened this issue Jan 18, 2016 · 19 comments
Assignees
Milestone

Comments

@fuzeman
Copy link
Contributor

fuzeman commented Jan 18, 2016

Roughly this would involve the following additions/changes:

  • Parameter added to define available update channels (and labels) in plugin details, for example: {"master": "Stable", "beta": "Beta", "develop: "Development"}
  • Controls to change/select the update channel on plugins
    • Drop-down to select update channel for new installs
    • Drop-down + button to change the update channel for existing plugins (this will also re-install the plugin from the selected channel)
    • Store selected update channel in Dict['installed']
  • Changes to git class to support update channel selection

Don't mind working on this myself and sending through a PR, just interested what your thoughts are before starting on anything.

@ukdtom
Copy link
Owner

ukdtom commented Jan 18, 2016

Well......To be frank, I suspect only Trakt use this ;-)

And do have this one open:
#110

But do go ahead, and start working on it, and suggest you use the tommy-work branch as foundation here, since the backend is most updated in that branch

/T

@ukdtom
Copy link
Owner

ukdtom commented Jan 18, 2016

And if so, then do remember to update the odt doc in Code/Docs as well, so the frontend knows what to call

@ukdtom
Copy link
Owner

ukdtom commented Jan 18, 2016

Ohh....And maybe:

{"master": {"Stable" : True}, "beta": {"Beta":False}, "develop: {"Development":False}}

With above, Gui would then know what the default should be

@ukdtom
Copy link
Owner

ukdtom commented Jan 18, 2016

And even better:

{"master": {"Stable" : True}, "beta": {"Beta":False}, "develop: {"Development":False}, "release":{"assetName":False}}

With the last one, we also nails issue 110, so......

Are you up for the task?

@fuzeman
Copy link
Contributor Author

fuzeman commented Jan 18, 2016

Happy to work on this, but would probably need to leave it to next week before I have some time to work on it.

@ukdtom
Copy link
Owner

ukdtom commented Jan 18, 2016

NP, and looking forward, cuz as you might have noticed, when looking @ my code so far, I'm not a professional developer, so my implementation to this would end up working, but would be kinda basic ;-)

So looking forward for your magic here ;-)

@ukdtom ukdtom modified the milestone: V2.2 Jan 23, 2016
fuzeman added a commit to fuzeman/WebTools.bundle that referenced this issue Mar 10, 2016
@fuzeman
Copy link
Contributor Author

fuzeman commented Mar 10, 2016

Finally had some time to work on this feature, check out my feature/update-channels branch (based off the micke-work branch) for the current implementation.

Let me know if you find any issues with the implementation, happy to make any changes as needed.


UI:

@fuzeman
Copy link
Contributor Author

fuzeman commented Mar 10, 2016

Format of plugin details is:

    {
        "title"           :     "Trakt.tv",
        "bundle"          :     "Trakttv.bundle",
        "type"            :     ["Application", "Social"],
        "description"     :     "Keep track of TV shows and movies you watch, synchronize your watched history and ratings between applications, and use the trakt.tv website to see upcoming episodes on a calendar, participate in the community and discover new TV shows and movies.",
        "repo"            :     "https://github.com/trakt/Plex-Trakt-Scrobbler",
        "branches"        :     [
            {"name": "master", "label": "Stable"},
            {"name": "beta", "label": "Beta"}
        ],
        "identifier"      :     "com.plexapp.plugins.trakttv",
        "icon"            :     "trakt-icon.png",
        "supporturl"      :     "https://forums.plex.tv/discussion/102818"
    },

Note: Only plugins that want to use multiple update channels need the "branches" parameter, the "branch" parameter will be used as a fallback.

@ukdtom
Copy link
Owner

ukdtom commented Mar 13, 2016

Could be off track here, but don't you think we would need something indicating the default branch, that people should use, and make that preselected in the combo?

After all, most users has no clue as to what branch to select, or?

/T

@fuzeman
Copy link
Contributor Author

fuzeman commented Mar 13, 2016

Could be off track here, but don't you think we would need something indicating the default branch, that people should use, and make that preselected in the combo?

The first item in the "branches" list is currently the default.

Having a separate option would mean you could change the position (in the list) of the default branch, not sure how useful that would be though?

@ukdtom
Copy link
Owner

ukdtom commented Mar 13, 2016

Makes sense, and didn't spot that ;-)

Your code is flawless, so do go ahead, and make a PR against my thread

@ukdtom ukdtom modified the milestones: V2.3, V2.2 Mar 18, 2016
fuzeman added a commit to fuzeman/WebTools.bundle that referenced this issue Mar 18, 2016
@ukdtom ukdtom modified the milestones: V2.2, V2.3 Mar 21, 2016
@ukdtom
Copy link
Owner

ukdtom commented Mar 21, 2016

Fix checked in 0081275

Thanks

@ukdtom ukdtom closed this as completed Mar 21, 2016
@ukdtom ukdtom reopened this Mar 21, 2016
@ukdtom
Copy link
Owner

ukdtom commented Mar 21, 2016

Sadly broke manual install of a bundle, that's not in UAS, SNIFF

@ukdtom
Copy link
Owner

ukdtom commented Mar 21, 2016

And correction here, it's all manual installs, regardless of been in uas or not

@fuzeman
Copy link
Contributor Author

fuzeman commented Mar 22, 2016

Sadly broke manual install of a bundle, that's not in UAS, SNIFF

Woops, forgot about manual installations. Will work on getting this fixed now.

@fuzeman
Copy link
Contributor Author

fuzeman commented Mar 22, 2016

Should be fixed with #153, let me know if you find any other issues 😄

@ukdtom
Copy link
Owner

ukdtom commented Mar 23, 2016

Looks cool, and thanks....

Ohhhh....And your PR against UAS2Res......

Wanna update that with the branch stuff perhaps?

/T

@ukdtom
Copy link
Owner

ukdtom commented Jul 2, 2016

Changed lost!

On the http part!

@ukdtom
Copy link
Owner

ukdtom commented Jul 5, 2016

Fixed by @dagalufh in ac2aca7

@ukdtom ukdtom closed this as completed Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants