-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UAS: Multiple update channels (master, beta, develop) #120
Comments
Well......To be frank, I suspect only Trakt use this ;-) And do have this one open: But do go ahead, and start working on it, and suggest you use the tommy-work branch as foundation here, since the backend is most updated in that branch /T |
And if so, then do remember to update the odt doc in Code/Docs as well, so the frontend knows what to call |
Ohh....And maybe: {"master": {"Stable" : True}, "beta": {"Beta":False}, "develop: {"Development":False}} With above, Gui would then know what the default should be |
And even better: {"master": {"Stable" : True}, "beta": {"Beta":False}, "develop: {"Development":False}, "release":{"assetName":False}} With the last one, we also nails issue 110, so...... Are you up for the task? |
Happy to work on this, but would probably need to leave it to next week before I have some time to work on it. |
NP, and looking forward, cuz as you might have noticed, when looking @ my code so far, I'm not a professional developer, so my implementation to this would end up working, but would be kinda basic ;-) So looking forward for your magic here ;-) |
Finally had some time to work on this feature, check out my feature/update-channels branch (based off the Let me know if you find any issues with the implementation, happy to make any changes as needed. |
Format of plugin details is: {
"title" : "Trakt.tv",
"bundle" : "Trakttv.bundle",
"type" : ["Application", "Social"],
"description" : "Keep track of TV shows and movies you watch, synchronize your watched history and ratings between applications, and use the trakt.tv website to see upcoming episodes on a calendar, participate in the community and discover new TV shows and movies.",
"repo" : "https://github.com/trakt/Plex-Trakt-Scrobbler",
"branches" : [
{"name": "master", "label": "Stable"},
{"name": "beta", "label": "Beta"}
],
"identifier" : "com.plexapp.plugins.trakttv",
"icon" : "trakt-icon.png",
"supporturl" : "https://forums.plex.tv/discussion/102818"
}, Note: Only plugins that want to use multiple update channels need the "branches" parameter, the "branch" parameter will be used as a fallback. |
Could be off track here, but don't you think we would need something indicating the default branch, that people should use, and make that preselected in the combo? After all, most users has no clue as to what branch to select, or? /T |
The first item in the "branches" list is currently the default. Having a separate option would mean you could change the position (in the list) of the default branch, not sure how useful that would be though? |
Makes sense, and didn't spot that ;-) Your code is flawless, so do go ahead, and make a PR against my thread |
Fix checked in 0081275 Thanks |
Sadly broke manual install of a bundle, that's not in UAS, SNIFF |
And correction here, it's all manual installs, regardless of been in uas or not |
Woops, forgot about manual installations. Will work on getting this fixed now. |
Should be fixed with #153, let me know if you find any other issues 😄 |
Looks cool, and thanks.... Ohhhh....And your PR against UAS2Res...... Wanna update that with the branch stuff perhaps? /T |
Changed lost! On the http part! |
Roughly this would involve the following additions/changes:
{"master": "Stable", "beta": "Beta", "develop: "Development"}
Dict['installed']
git
class to support update channel selectionDon't mind working on this myself and sending through a PR, just interested what your thoughts are before starting on anything.
The text was updated successfully, but these errors were encountered: