Add prop to optionally disable lazy loading language modes #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickgirardo Upgrade |
|
Thanks for the quick merge, I'm updated and doing great |
nickgirardo
added a commit
to nickgirardo/personal-site
that referenced
this pull request
Aug 11, 2021
codemirror-react's default behavior is to automatically load language resource files when it is created. This doesn't work for me as I need to have my entire bundle prepared ahead of time. I created a pr to add the ability to disable this behavior uiwjs/react-codemirror#132 The maintainer was pretty quick to merge my change, so I can statically load resource files now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for the hard work maintaining this project, it's been super helpful to me so far!
In my set up it doesn't make sense to dynamically load the language resources (modes) at runtime. I want to have a complete bundle that can be delivered without the need for further network requests.
For this I've added an optional prop,
lazyLoadMode. This prop istrueby default, and if it istruenothing changes. If the prop isfalse, the language resources will not be automatically downloaded and need to be downloaded manually.The heart of the change is in
src/index.jsline 47.Just to reiterate, since this prop is
trueby default, this is not a breaking change!I've updated the types to add this prop, and I've updated the readme to give a quick example of how it can be used.
If there is anything else which needs to be done or anything I can do to assist the project, please feel free to let me know! Thanks for checking this out