Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default theme in vscode light init #688

Closed
wolfseb opened this issue Oct 5, 2024 · 1 comment
Closed

Default theme in vscode light init #688

wolfseb opened this issue Oct 5, 2024 · 1 comment

Comments

@wolfseb
Copy link

wolfseb commented Oct 5, 2024

react-codemirror/themes/vscode/src/light.ts

Lines 70 to 71 in 1064e2a

export function vscodeLightInit(options?: Partial<CreateThemeOptions>) {
const { theme = 'dark', settings = {}, styles = [] } = options || {};

Should the default be theme = 'light' here?
jaywcjlove added a commit that referenced this issue Oct 5, 2024
@jaywcjlove
style(vscode): fix default value issue for light mode. #688
661bfc9
jaywcjlove added a commit that referenced this issue Oct 5, 2024
@jaywcjlove
released v4.23.5 #688
ed1e515
@jaywcjlove
Copy link
Member

@wolfseb thx! upgrade v4.23.5

github-actions bot pushed a commit that referenced this issue Oct 5, 2024
@jaywcjlove
v4.23.4 style(vscode): fix default value issue for light mode. #688 6…
cd3a45e 
…61bfc9
github-actions bot pushed a commit that referenced this issue Oct 5, 2024
@jaywcjlove
v4.23.5 released v4.23.5 #688 ed1e515
2dc5095
@wolfseb wolfseb closed this as completed Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaywcjlove @wolfseb