Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(combine): reads font from the "font.serif" matplotlib param by default #25

Merged
merged 7 commits into from
May 8, 2024

Conversation

engeir
Copy link
Member

@engeir engeir commented May 1, 2024

This also adjusts the convert command to specify the DPI, allowing for much better control of the font size. The font size is now read from the matplotlib params, meaning pointsize 8 when used with the default cosmoplots style.

This also adjusts the `convert` command to specify the DPI, allowing for
much better control of the font size. The font size is also read from
the matplotlib params.
@engeir engeir added the enhancement New feature or request label May 1, 2024
@engeir engeir requested a review from audunth May 2, 2024 07:04
@audunth
Copy link
Contributor

audunth commented May 2, 2024

Når jeg printer innholdet i subprocess.call er det fortsatt 'Times-New-Roman' som brukes som font. Mulig bugfix i #26 hjelper?

@engeir
Copy link
Member Author

engeir commented May 2, 2024

Skjer det også hvis du aldri kaller på using()? Tror det burde fungere om ikke den metoden kalles.

@engeir
Copy link
Member Author

engeir commented May 2, 2024

#26 er nå merget inn, så det burde fungere i begge tilfeller nå.

@engeir engeir merged commit 9f65fad into main May 8, 2024
10 checks passed
@engeir engeir deleted the combine-better-defaults branch May 8, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants