fix(axis): remove deprecation warning #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I modified the comments so it is hopefully clearer if we discuss the x-axis, y-axis (or both), or the axes object. Also, the readme now demonstrates that change_log_axis_base automatically finds the correct axis. |
audunth
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecation warning when using
change_log_axis_base, since thecosmoplots.mplstyledoes not fully cover it's feature set.This also removes the need to specify what axis should be updated by instead making an attempt to infer it based on the plotting methods that has been used ("loglog", "semilogx", ...). This of course only works if
plt.loglogis called beforechange_log_axis_base.