feat(plotting): concatenate plots in a subfigure layout #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the project assumes python >=3.8, and 3.8 is also the lowest supported version now that 3.12 is out, this class shouldn't use python >=3.11 features. https://devguide.python.org/versions/
Not yet sure how ImageMagick should be installed on Windows.
The tempfile module already create temporary directories that are unique.
|
The output seems to be a .png no matter what the input is (replacing all .png in the readme with .jpg or .eps still produces a .png output). Is convert able to keep .eps - vector formats? |
|
Yes I agree thats an issue. I think the last commit fixes it. |
|
I don't think convert preserves the vector format of .eps - it just turns the original .eps into an image and then converts the result to .eps. This is not something we can fix here. |
audunth
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small class that calls
imagemagickand creates a figure with subfigures. Useful for standardizing figure layouts as a replacement for the latex subfigure environment.The font type, font size, color, position and text of the labels can be changed from the default.
It should be able to provide the amount of flexibility typically needed, but also extending the class should hopefully be straight forward. A help method is available which prints the
imagemagickcommands that are used under the hood.This PR also adds some tests for this class only, run against ubuntu-latest.