Color swatches from color maps that are suitable for grayscale printing #12
Conversation
README.md
Outdated
| import cosmoplots | ||
|
|
||
| color_list = cosmoplots.generate_hex_colors(5, 'viridis', show_swatch=True, ascending=True) | ||
| plt.savefig("/assets/color_test.png") |
There was a problem hiding this comment.
Missing a . in the path: -> ./assets/color_test.png.
There was a problem hiding this comment.
Thanks for spotting. Done!
README.md
Outdated
| @@ -52,6 +52,23 @@ ax.plot(a) | |||
| plt.show() | |||
| ``` | |||
|
|
|||
| ## `generate_hex_colors` | |||
There was a problem hiding this comment.
I would move this to the end of the markdown file, so that the figure showing matplotlib vs cosmoplots is shown earlier.
There was a problem hiding this comment.
I've moved it to the bottom now
README.md
Outdated
| plt.savefig("./assets/color_test.png") | ||
|
|
||
| # Print color_list to retrieve the hex numbers | ||
| print(color_list) |
There was a problem hiding this comment.
When I run these lines in my terminal the last line prints out
['#fde725', '#5ec962', '#21918c', '#3b528b', '#440154']
Maybe add the output or remove the last line in order to be consistent.
There was a problem hiding this comment.
Okay, I've added the output
|
@engeir Do you think this looks good? |
|
I am happy with this. One thing that might be worth adjusting it the style of the docstrings, since elsewhere in the repo numpy style is used, it might be good to keep consistency. I.e., instead of """...
Args:
param: type
desc
Return:
type
desc
""""""...
Parameters
----------
param: type
desc
Returns
-------
type
desc
""" |
cosmoplots/colors.py
Outdated
| Generate plot of the desired color swatches. This is useful if you want to see what the swatches look like. | ||
| This function is used in generate_hex_colors() where the plot of the swatches will show by default if used in Jupyter Notebook. | ||
|
|
||
| Args: |
There was a problem hiding this comment.
Since numpy style is used elsewhere, maybe change from
Args:
to
Parameters
----------
and similar for the rest.
There was a problem hiding this comment.
I've adjusted the style, how is it now?
cosmoplots/colors.py
Outdated
|
|
||
| Returns | ||
| ------- | ||
| color_swatch: |
cosmoplots/colors.py
Outdated
| from typing import List | ||
|
|
||
|
|
||
| def make_color_swatch(color_list: list): |
hex_colors_example.png
Outdated
No description provided.