Merge pull request #465 from uidu-org/fix-editor-flex

docs(changeset): Better tabIndex managment for phone fields
uidu-org · Sep 16, 2024 · dcc0b5f · dcc0b5f
2 parents 06c740f + e324ab5
commit dcc0b5f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/.changeset/kind-spoons-bake.md b/.changeset/kind-spoons-bake.md
@@ -0,0 +1,6 @@
+---
+'@uidu/data-fields': minor
+'@uidu/table': minor
+---
+
+Better tabIndex managment for phone fields
diff --git a/packages/data/data-fields/src/fields/phone/Cell.tsx b/packages/data/data-fields/src/fields/phone/Cell.tsx
@@ -19,6 +19,7 @@ export default function Cell<T>({ getValue }: CellContext<T, string>) {
           target="_blank"
           tw="p-1 ml-auto flex"
           rel="noopener noreferrer"
+          tabIndex={-1}
         >
           <svg
             xmlns="http://www.w3.org/2000/svg"

diff --git a/packages/data/table/src/components/Cell.tsx b/packages/data/table/src/components/Cell.tsx
@@ -140,6 +140,7 @@ function Cell<T, V>({
       $pinned={cell.column.columnDef.meta?.pinned}
       $index={index}
       $height={rowHeight}
+      role="gridcell"
       tabIndex={-1}
       onDoubleClick={(e) => {
         e.preventDefault();