Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zef not coping with parental controls / filters / proxies doing wrong things #292

Open
lizmat opened this issue Mar 7, 2019 · 2 comments
Open

zef not coping with parental controls / filters / proxies doing wrong things #292

lizmat opened this issue Mar 7, 2019 · 2 comments

Comments

@lizmat
Copy link
Contributor

lizmat commented Mar 7, 2019

It looks like zef has a bad failure mode if the file obtained from the ecosystem is being blocked / redirected / replaced by garbage that is not the right JSON: like the ecosystem is empty.

Spotted at the GPW of which the WiFi apparently had some parental controls enabled on one of the outer routers.
@lizmat lizmat changed the title zef not copying with parental controls / filters / proxies doing wrong things zef not coping with parental controls / filters / proxies doing wrong things Mar 7, 2019
@ugexe
Copy link
Owner

ugexe commented Mar 8, 2019

zef/lib/Zef/Repository/Ecosystems.pm6

Line 94 in 7c9d05b

try |from-json(.slurp);

The above should probably fail if it gets invalid json. So this should probably throw, and be caught inside Zef::Repository (where it gets called) to deliver the exception message via $logger.emit(...).

ugexe added a commit that referenced this issue Mar 16, 2019
@ugexe
Gracefully handle invalid package list formats
25d0150 
If the content of the package list is not valid json then report
this to the user and don't overwrite any (possibly) existing
valid json package list.

Resolves #292
@tbrowder
Copy link

Is this issue closable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ugexe @tbrowder @lizmat