Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UW-649 Docs for uw execute tool #569

Merged
merged 17 commits into from
Aug 9, 2024
Merged

UW-649 Docs for uw execute tool #569

merged 17 commits into from
Aug 9, 2024

Conversation

maddenp-noaa
Copy link
Contributor

@maddenp-noaa maddenp-noaa commented Aug 8, 2024 •
edited
Loading

Synopsis

Add RST docs for uw execute external-driver tool. See this page in particular.

Type

  • Documentation

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@maddenp-noaa maddenp-noaa self-assigned this Aug 8, 2024
@maddenp-noaa maddenp-noaa marked this pull request as ready for review August 8, 2024 23:50
NaureenBharwaniNOAA
NaureenBharwaniNOAA approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@NaureenBharwaniNOAA NaureenBharwaniNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Quick two comments about possibly unused example files.

docs/sections/user_guide/cli/tools/execute/alt.schema Outdated Show resolved Hide resolved
docs/sections/user_guide/cli/tools/execute/alt.yaml Outdated Show resolved Hide resolved
christinaholtNOAA
christinaholtNOAA approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One suggestion below, but I'm also fine as-is.

docs/sections/user_guide/cli/tools/execute.rst Show resolved Hide resolved
WeirAE
WeirAE approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@WeirAE WeirAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick updates

@maddenp-noaa maddenp-noaa merged commit 81fd471 into ufs-community:main Aug 9, 2024
2 checks passed
@maddenp-noaa maddenp-noaa deleted the uw-649-execute-docs branch August 9, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NaureenBharwaniNOAA NaureenBharwaniNOAA NaureenBharwaniNOAA approved these changes

@christinaholtNOAA christinaholtNOAA christinaholtNOAA approved these changes

@WeirAE WeirAE WeirAE approved these changes

@elcarpenterNOAA elcarpenterNOAA elcarpenterNOAA approved these changes

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr fgabelmannjr is a code owner

Assignees

@maddenp-noaa maddenp-noaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maddenp-noaa @christinaholtNOAA @WeirAE @NaureenBharwaniNOAA @elcarpenterNOAA