Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UW-269 Extend set_config.py tool to "export" variables #280

Merged
merged 21 commits into from
Aug 18, 2023

Conversation

elcarpenterNOAA
Copy link
Contributor

@elcarpenterNOAA elcarpenterNOAA commented Aug 14, 2023

Description

For Issue #272

We will need to be able run a command line tool in bash that "exports" the variables in a given section of our YAML or INI file.

It was decided that the cli code was out of scope for this ticket and instead part of the modal-cli ticket planned for the next sprint.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

src/uwtools/config.py Outdated Show resolved Hide resolved
src/uwtools/config.py Outdated Show resolved Hide resolved
src/uwtools/config.py Outdated Show resolved Hide resolved
src/uwtools/config.py Outdated Show resolved Hide resolved
src/uwtools/config.py Outdated Show resolved Hide resolved
Copy link
Contributor

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really nice. :)

src/uwtools/config.py Outdated Show resolved Hide resolved
src/uwtools/config.py Show resolved Hide resolved
src/uwtools/config.py Outdated Show resolved Hide resolved
src/uwtools/config.py Outdated Show resolved Hide resolved
src/uwtools/config.py Outdated Show resolved Hide resolved
src/uwtools/config.py Outdated Show resolved Hide resolved
src/uwtools/config.py Show resolved Hide resolved
src/uwtools/config.py Outdated Show resolved Hide resolved
src/uwtools/config.py Outdated Show resolved Hide resolved
src/uwtools/config.py Outdated Show resolved Hide resolved
Copy link
Contributor

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elcarpenterNOAA This looks great!

Please take my only comment below with a grain of salt. I'm 💯 fine with whatever you decide to do there (ignoring me included)!

src/uwtools/config.py Outdated Show resolved Hide resolved
maddenp-noaa
maddenp-noaa previously approved these changes Aug 18, 2023
@elcarpenterNOAA elcarpenterNOAA merged commit c2705b4 into develop Aug 18, 2023
1 check passed
@elcarpenterNOAA elcarpenterNOAA deleted the emily/UW-269 branch August 18, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants