MERRA2 diagnosed number concentrations of ice friendly (NIFA) and liquid friendly aerosols (NWFA)#951
Closed
AnningCheng-NOAA wants to merge 2 commits into
Closed
Conversation
Collaborator
|
@AnningCheng-NOAA Since this PR hasn't been ready for a while, I will close it. Please open a new PR when you have the code updates ready. Thanks |
Contributor
Author
|
sure, Jun
…On Thu, Apr 21, 2022 at 9:01 PM Jun Wang ***@***.***> wrote:
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> Since this PR
hasn't been ready for a while, I will close it. Please open a new PR when
you have the code updates ready. Thanks
—
Reply to this email directly, view it on GitHub
<#951 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIINVRG6HCRTSMB6MHLVGH27BANCNFSM5JWQT5WA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
zhanglikate
pushed a commit
to zhanglikate/ufs-weather-model
that referenced
this pull request
Oct 20, 2025
…D_CI_TESTING in CMake, to allow ufs-weather-model to use BUILD_TESTING ufs-community#920 + Fix for JEDI cubed sphere grid ufs-community#951 (ufs-community#931) * change cmake option BUILD_TESTING to BUILD_CI_TESTING * fixed workflow * Reorganize project structure to allow multiple dycores. Isolate FV3 dycore. * Fix JEDI cubed sphere grid and issue with time unlimited --------- Co-authored-by: Edward Hartnett <edward.hartnett@noaa.gov> Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?
MERRA2 climatological aerosols are used to calculate number concentrations of ice friendly (NIFA) and liquid friendly aerosols (NWFA). So IN and CCN can be activated using aerosol. This approach is about 10% less expensive than the forecast approach. The indirect interaction of aerosol and clouds is expected to happen
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs