Update to CA scale parameters for better scaling across resolutions; Fix regression testing and throttled builds on S4 (was #896)#888
Conversation
lisa-bengtsson
changed the title
|
Lisa, your PR is next in the commit queue. We would like to combine yours with PR #896, which changes only two files at the script level. Would you please update your branch to the latest ufs-weather, bring in David's changes and then update the BL_DATE to |
|
Yes, I can do that. I will start by merging with the latest develop. |
|
What is the best way to merge with PR #896 ? Should I manually update those lines in tests/detect_machine.sh and tests/rt.sh ? |
|
Given the scale of the changes, I think that would be fine. @DavidHuber-NOAA would you check Lisa's branch after she adds your changes to make sure all is correct? |
|
@DeniseWorthen Sure, will do. |
|
@DavidHuber-NOAA OK, you can have a look in those two files now, thanks! |
|
@DeniseWorthen is BL_DATE only in rt.sh? |
|
@lisa-bengtsson Looks good, thank you! |
|
Yes, BL_DATE is only in rt.sh (LN 463) |
|
Ok, I have merged with develop and PR 894 and updated BL_DATE. Let me know if you need me to do anything else. Thanks. |
DeniseWorthen
changed the title
DeniseWorthen
requested review from
DavidHuber-NOAA,
MinsukJi-NOAA and
junwang-noaa
DeniseWorthen
added
the
Waiting for Reviews
|
All tests passed; ready to start commit. |
|
@lisa-bengtsson could you revert your submodules? It looks like both FV3 and stoch have been merged. |
* add vegetation_type to the chemistry export * more updates for vegtype
7 participants
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
This PR improves the way the CA scales across resolutions. New baselines are required.
Tested operational test requirement tests, which all passed.
Issue(s) addressed
ufs-weather-model issue #818
fixes #896
Testing
Dependencies
Related PR's:
NOAA-EMC/ufsatm#414
NOAA-PSL/stochastic_physics#49