Update CDEPS component and remove DATM component by binli2337 · Pull Request #845 · ufs-community/ufs-weather-model

binli2337 · 2021-10-01T14:27:25Z

PR Checklist

Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

The CDEPS component will be updated to include the latest changes from ESCOMP/CDEPS.
The DATM component will be removed and related scripts and configuration files will also be removed.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

waiting on Update develop branch of cdeps to the most recent version of ESCOMP/CDEPS NOAA-EMC/CDEPS#37

CDEPS points to a recently updated version

revise parm/nems.configure.hafs_atm_docn.IN revise parm/nems.configure.hafs_atm_ocn.IN remove DATM

binli2337 · 2021-10-15T13:47:23Z

@junwang-noaa The code is ready.

junwang-noaa · 2021-10-15T13:54:43Z

I started RT on cray

…

On Fri, Oct 15, 2021 at 9:47 AM BinLi-NOAA ***@***.***> wrote: @junwang-noaa <https://github.com/junwang-noaa> The code is ready. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#845 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI7D6TPVJDHGHRGPZIFNBODUHAWHLANCNFSM5FE2I7QA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

on-behalf-of @ufs-community

DeniseWorthen · 2021-10-15T14:46:18Z

There are still some remaining files w/ references to NEMSDatm: cmake/configure_apps.cmake and CMakeLists.txt.

I also think we need to clean up the NEMS/src/module_EARTH_GRID_component, which has both FRONT_NEMS_DATM and FRONT_CDEPS_DATM. This would have required a NEMS PR also.

DeniseWorthen · 2021-10-15T17:39:20Z

@binli2337 I've removed the run directory. It isn't actually necessary to delete them before re-running the auto-RT.

binli2337 · 2021-10-15T17:55:52Z

@DeniseWorthen Thanks!

on-behalf-of @ufs-community

BrianCurtis-NOAA · 2021-10-15T18:42:40Z

Automated RT Failure Notification
Machine: cheyenne
Compiler: gnu
Job: RT
Repo location: /glade/scratch/dtcufsrt/autort/tests/auto/pr/747670691/20211015120014/ufs-weather-model
Please manually delete: /glade/scratch/dtcufsrt/FV3_RT/rt_69000
Test control_thompson_extdiag_debug 025 failed failed
Test control_thompson_extdiag_debug 025 failed in run_test failed
Test control_diag_debug 017 failed failed
Test control_diag_debug 017 failed in run_test failed
Please make changes and add the following label back:
cheyenne-gnu-RT

DeniseWorthen · 2021-10-15T18:49:30Z

The control_thompson_extdiag_debug failure on cheyenne was

77:mp_thompson_post_run: ttendlim applied 1/4064 times at timestep 1
144:
144:Program received signal SIGFPE: Floating-point exception - erroneous arithmetic operation.
144:
144:Backtrace for this error:
144:#0  0x2b697cd00aff in ???
144:#1  0x10b8723 in ???
144:#2  0x10b78a1 in ???
144:#3  0x10b62fa in ???

I'll try copying the run directory and try re-running.

The control_diag_debug was a time-out.

* control_thompson_extdiag_debug and control_diag_debug were re-run manually

on-behalf-of @ufs-community

junwang-noaa · 2021-10-18T00:55:12Z

@binli2337 cray log file is at: /scratch1/NCEPDEV/stmp2/Jun.Wang/wcosslog/RegressionTests_wcoss_cray.log

DeniseWorthen · 2021-10-18T13:05:16Z

It looks like CDEPS has been updated, so once the submodule is reverted I will approve.

…NOAA-EMC/CDEPS.

climbfuji

Nice cleanup work!

* send CCPP ebu_smoke to UPP ebb * upp: remove GSD_NC synonyms and rename GSD_NC fields instead * update upp hash: g2, g2tmpl, etc. * upp: correct pressure levels for hafs-ar postxconfig files * bugfix: fixed_sfc2_type defaults to fixed_sfc1_type * Add aerosol fix from Li Pan. --------- Co-authored-by: Wen Meng <Wen.Meng@noaa.gov>

DavidHuber-NOAA and others added 6 commits September 30, 2021 10:56

Added python with netcdf to RT on S4. (ufs-community#842)

07d467d

Merge remote-tracking branch 'upstream/develop' into fix_py_s4

3d5e71a

remove files related to datm tests and clean up scripts

8cb26e6

CDEPS points to a recently updated version

Merge remote-tracking branch 'upstream/develop' into fix_py_s4

b708bb7

revise parm/nems.configure.datm_cdeps.IN

9a0eaa9

revise parm/nems.configure.hafs_atm_docn.IN revise parm/nems.configure.hafs_atm_ocn.IN remove DATM

Merge branch 'develop' into cdeps_update_datm_cleanup

009ccd7

binli2337 self-assigned this Oct 1, 2021

binli2337 added the No Baseline Change No Baseline Change label Oct 1, 2021

binli2337 and others added 7 commits October 1, 2021 17:00

Merge branch 'develop' into cdeps_update_datm_cleanup

b66c083

Merge branch 'ufs-community:develop' into cdeps_update_datm_cleanup

ee5df02

remove cpld_datm_cfsr.IN and cpld_datm_gefs.IN

db11e84

Merge branch 'develop' into cdeps_update_datm_cleanup

ede97f2

Revised InputsOutputs.rst

9446b1a

Merge remote-tracking branch 'upstream/develop' into fix_py_s4

c37aba6

Merge branch 'fix_py_s4' into cdeps_update_datm_cleanup

113d52e

binli2337 added the hera-intel-RT label Oct 15, 2021

junwang-noaa requested review from DeniseWorthen, DusanJovic-NOAA and MinsukJi-NOAA October 15, 2021 13:39

BrianCurtis-NOAA removed the hera-intel-RT label Oct 15, 2021

MinsukJi-NOAA added the run-ci label Oct 15, 2021

github-actions Bot removed the run-ci label Oct 15, 2021

MinsukJi-NOAA added the run-ci label Oct 15, 2021

github-actions Bot removed the run-ci label Oct 15, 2021

RT JOBS PASSED: hera.intel. Log file uploaded.

fee1567

on-behalf-of @ufs-community

binli2337 added cheyenne-gnu-RT labels Oct 15, 2021

RT JOBS PASSED: hera.gnu. Log file uploaded.

a464107

on-behalf-of @ufs-community

binli2337 added the cheyenne-gnu-RT label Oct 15, 2021

BrianCurtis-NOAA removed the cheyenne-gnu-RT label Oct 15, 2021

DeniseWorthen and others added 2 commits October 15, 2021 14:36

add cheyenne.gnu log

eec9b34

* control_thompson_extdiag_debug and control_diag_debug were re-run manually

RT JOBS PASSED: orion.intel. Log file uploaded.

d9ca74f

on-behalf-of @ufs-community

binli2337 added the jet-intel-RT label Oct 16, 2021

BrianCurtis-NOAA removed the jet-intel-RT label Oct 16, 2021

BrianCurtis-NOAA and others added 2 commits October 16, 2021 13:59

RT JOBS PASSED: jet.intel. Log file uploaded.

da50c2e

on-behalf-of @ufs-community

add wcoss_dell_p3 log file

74bad3e

binli2337 added the Waiting for Reviews The PR is waiting for reviews from associated component PR's. label Oct 17, 2021

junwang-noaa approved these changes Oct 18, 2021

View reviewed changes

add wcoss_cray log file

77c22cb

binli2337 mentioned this pull request Oct 18, 2021

Fix regression tests on S4 #843

Closed

15 tasks

DusanJovic-NOAA approved these changes Oct 18, 2021

View reviewed changes

modify .gitmodules to point CDEPS submodule to the develop branch of …

4d34580

…NOAA-EMC/CDEPS.

climbfuji approved these changes Oct 18, 2021

View reviewed changes

DeniseWorthen approved these changes Oct 18, 2021

View reviewed changes

MinsukJi-NOAA approved these changes Oct 18, 2021

View reviewed changes

junwang-noaa merged commit 7d812f9 into ufs-community:develop Oct 18, 2021

binli2337 mentioned this pull request Oct 18, 2021

Remove NEMS_DATM component from ufs-weather-model #565

Closed

binli2337 deleted the cdeps_update_datm_cleanup branch October 26, 2021 14:13

zach1221 mentioned this pull request Aug 23, 2024

sync with head of NOAA-EMC UPP develop #2326

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update CDEPS component and remove DATM component#845

Update CDEPS component and remove DATM component#845
junwang-noaa merged 24 commits into
ufs-community:developfrom
binli2337:cdeps_update_datm_cleanup

binli2337 commented Oct 1, 2021 •

edited by MinsukJi-NOAA

Loading

Uh oh!

binli2337 commented Oct 15, 2021

Uh oh!

junwang-noaa commented Oct 15, 2021 via email

Uh oh!

DeniseWorthen commented Oct 15, 2021

Uh oh!

DeniseWorthen commented Oct 15, 2021

Uh oh!

binli2337 commented Oct 15, 2021

Uh oh!

BrianCurtis-NOAA commented Oct 15, 2021

Uh oh!

DeniseWorthen commented Oct 15, 2021 •

edited

Loading

Uh oh!

junwang-noaa commented Oct 18, 2021

Uh oh!

DeniseWorthen commented Oct 18, 2021

Uh oh!

climbfuji left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

binli2337 commented Oct 1, 2021 • edited by MinsukJi-NOAA Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Instructions: All subsequent sections of text should be filled in as appropriate.

Description

Issue(s) addressed

Testing

Dependencies

Uh oh!

binli2337 commented Oct 15, 2021

Uh oh!

junwang-noaa commented Oct 15, 2021 via email

Uh oh!

DeniseWorthen commented Oct 15, 2021

Uh oh!

DeniseWorthen commented Oct 15, 2021

Uh oh!

binli2337 commented Oct 15, 2021

Uh oh!

BrianCurtis-NOAA commented Oct 15, 2021

Uh oh!

DeniseWorthen commented Oct 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

junwang-noaa commented Oct 18, 2021

Uh oh!

DeniseWorthen commented Oct 18, 2021

Uh oh!

climbfuji left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

binli2337 commented Oct 1, 2021 •

edited by MinsukJi-NOAA

Loading

DeniseWorthen commented Oct 15, 2021 •

edited

Loading