Skip to content

cmake in the FV3 dycore#812

Merged
DusanJovic-NOAA merged 41 commits into
ufs-community:developfrom
aerorahul:feature/cmake_only_in_dycore_of_emc
Sep 23, 2021
Merged

cmake in the FV3 dycore#812
DusanJovic-NOAA merged 41 commits into
ufs-community:developfrom
aerorahul:feature/cmake_only_in_dycore_of_emc

Conversation

@aerorahul
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul commented Sep 16, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

Description

This PR moves the CMake build of the dycore from fv3atm into GFDL_atmos_cubed_sphere

Is a change of answers expected from this PR? No
Are any library updates included in this PR (modulefiles etc.)? No

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@aerorahul aerorahul marked this pull request as ready for review September 17, 2021 15:18
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: RT
Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/735741103/20210922143009/ufs-weather-model
Please manually delete: /scratch1/NCEPDEV/stmp2/emc.nemspara/FV3_RT/rt_2710
Test cpld_restart 002 failed failed
Test cpld_restart 002 failed in run_test failed
Please make changes and add the following label back:
hera-intel-RT

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: RT
Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/735741103/20210922143009/ufs-weather-model
Please manually delete: /scratch1/NCEPDEV/stmp2/emc.nemspara/FV3_RT/rt_2710
Test cpld_restart 002 failed failed
Test cpld_restart 002 failed in run_test failed
Please make changes and add the following label back:
hera-intel-RT

31 min. TEST 002 cpld_restart is running,  status: R jobid 23426475
Slurm unknown status -. Check sacct ...
23426475                  TIMEOUT          rt_2710_002 
23426475.ba+            CANCELLED                batch 
23426475.ex+            COMPLETED               extern 
23426475.0                 FAILED              fv3.exe 
32 min. TEST 002 cpld_restart is TIMEOUT,  status: - jobid 23426475

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

Automated RT Failure Notification
Machine: jet
Compiler: intel
Job: RT
Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/735741103/20210922143017/ufs-weather-model
Please manually delete: /lfs4/HFIP/h-nems/emc.nemspara/RT_RUNDIRS/emc.nemspara/FV3_RT/rt_147530
Test cpld_control_wave 014 failed in run_test failed
Please make changes and add the following label back:
jet-intel-RT

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator

Automated RT Failure Notification
Machine: jet
Compiler: intel
Job: RT
Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/735741103/20210922143017/ufs-weather-model
Please manually delete: /lfs4/HFIP/h-nems/emc.nemspara/RT_RUNDIRS/emc.nemspara/FV3_RT/rt_147530
Test cpld_control_wave 014 failed in run_test failed
Please make changes and add the following label back:
jet-intel-RT

$ tail log_jet.intel/run_014_cpld_control_wave.log 
+ __set_x='set -x'
+ set +x
+ [[ slurm = \n\o\n\e ]]
+ [[ false = \f\a\l\s\e ]]
+ submit_and_wait job_card
+ [[ -z job_card ]]
+ '[' -o xtrace ']'
+ set_x='set -x'
+ set +x
sbatch: error: Batch job submission failed: Socket timed out on send/recv operation

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

Automated RT Failure Notification
Machine: gaea
Compiler: intel
Job: RT
Repo location: /lustre/f2/pdata/ncep/emc.nemspara/autort/pr/735741103/20210922143008/ufs-weather-model
Please manually delete: /lustre/f2/scratch/emc.nemspara/FV3_RT/rt_46398
Test cpld_ca 005 failed failed
Test cpld_ca 005 failed in run_test failed
Please make changes and add the following label back:
gaea-intel-RT

@DusanJovic-NOAA DusanJovic-NOAA merged commit f04a30c into ufs-community:develop Sep 23, 2021
@aerorahul aerorahul deleted the feature/cmake_only_in_dycore_of_emc branch September 23, 2021 15:48
grantfirl added a commit to grantfirl/ufs-weather-model that referenced this pull request Dec 22, 2021
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model that referenced this pull request Apr 4, 2023
* update submodule pointer for regression testing of ccpp-physics#812
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
* Construct var_defns components from dictionary.

* Bring back config_defaults.yaml

* Add support for sourcing yaml file into shell script.

* Remove newline for printing config, json config fix.

* Make QUILTING a sub-dictionary in predef_grids

* Reorganize config_defaults.yaml by task and feature.

* Bug fix with QUILTING=true.

* Structure a dictionary based on a template dictionary.

* Convert all WE2E config files to yaml.

* Take care of problematic chars when converting to shell string.

* Process only selected keys of config.

* Add symlinked yaml config files.

* Actually use yaml config files for WE2E tests.

* Delete all shell WE2E configs.

* Don't check for single quotes in test description.

* Make WE2E work with yaml configs.

* Make yaml default config format.

* Bug fix in run_WE2E script.

* Add utility to check validity of yaml config file.

* Add config utility interface in ush directory.

* Remove unused check_expt_config_vars script.

* Add description to default config.

* Reorganize source_config.

* Add XML as one of the config formats.

* Update custom_ESGgrid config.

* Bug fix due to update.

* Change ensemble seed.

* Change POST_OUTPUT group due to merge.

* Make xml and ini configs work.

* Maintain config structure down to var_defns.

* Add function to load structured shell config, put description under metadata

* Flatten dicts before importing env now that shell config is structured.

* Support python regex for selecting dict keys.

* Add capability of sourcing task specific portion of config file.

* Access var_defns via env variable.

* Make names of tasks consistent with ex- and j- job script names.

* Append pid to temp file.

* Prettify user config, don't use " in xml texts.

* Compare timestamp of csv vs all files instead of directory.

* Fixes for some pylint suggestions.

* Convert new configs to yaml.

* Format python files with black (no functional change).

* More readable yaml/json formats by using more data types.
Only datetime type is now in quotes.

* More readable yaml config files for WE2E and default configs.

* Make config_defaults itself more readable.

* Correct pyyaml list indentation issue.

* Fix indentation in all config files.

* Use unquoted WTIME in config_defaults

* Cosmotic changes.

* Fix due to merge.

* Make __init__.py clearer.

* Fixes due to merge.

* Minor edits of comments.

* Remove wcoss_dell_p3 from workflow (#810)

* remove wcoss_dell_p3

* remove block for tide and gyre

* Replace deprecated NCAR python environment with conda on Cheyenne (#812)

* Fix issue on get_extrn_lbcs when FCST_LEN_HRS>=40 with netcdf (#814)

* activate b file on hpss for >40h

* add a new we2e test for fcst_len_hrs>40

* reduce fcst time for we2e

* Convert new test case to yaml.

* Fix formatting due to merge.

* Convert new test case to yaml.

* Fix unittest.

* Merge develop

* Remove exception logic from __init__.py

* Minor change to cmd concat.

* Make grid gen methods return dictionary, simplifis code a lot.

* Add a comment why we are suppressing yaml import exception.

* Minor change to beautify unittest output.

* Add status badge for functional tests.

* Reorder tasks in config_default and we2e test cases to match order in FV3LAM.xml

* Keep single quotes and newlines in we2e test description.

* Revert back to not rounding to 10 digits

Co-authored-by: Chan-Hoo.Jeon-NOAA <60152248+chan-hoo@users.noreply.github.com>
Co-authored-by: Michael Kavulich <kavulich@ucar.edu>
zhanglikate pushed a commit to zhanglikate/ufs-weather-model that referenced this pull request Oct 20, 2025
* Update io/module_write_netcdf.F90 (ufs-community#810)

* [production/RRFS.v1] Fix improperly assigned fire emissions for ebb_dcycle==1 for retrospectives (NOT operational!) (ufs-community#812)

* Fix improperly assigned fire emissions for ebb_dcycle==1 for retrospectives (NOT operational!)

* Move ebu_smoke outside of extended_sd_diag IF block in diagnostics

---------

Co-authored-by: jordanschnell <jordan.schnell@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No Baseline Change Waiting for Reviews The PR is waiting for reviews from associated component PR's.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move cmake build of dycore from fv3atm to dycore.

7 participants