Update CICE for advanced snow physics, history file timestamping and history file precision#757
Conversation
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
I cannot comment on the CICE changes, but the changes in this PR are straightforward. Hopefully the Gaea issues will be addressed soon by the sysadmins so that we can reduce the wallclock time for compile jobs and run jobs again.
|
Automated RT Failure Notification |
* two tests timed out and were run manually. The hafs_regional_atm_ocn test passed with atmf006.nc using "ALT CHECK". The previous commit passed atmf006.nc with direct comparison
|
Automated RT Failure Notification |
|
Automated RT Failure Notification |
|
I think the failed Gaea test revealed a problem with how the The rt.conf has: So regional_restart is both run during baseline creation and is dependent on regional_control. The The Gaea Auto-BL reported a failure for When Auto-BL reported that When Auto-RT reported that But in fact the I can go back and create the |
* regional_control/restart and control_stochy/restart were run manually
* all jobs ran and passed, but main log file was not created. * created a substitue log from the individual rt_*log files
|
Automated RT Failure Notification |
|
All the Orion failures were time-outs. I can retrieve all but three from my attempt at a manual BL creation. I'll need to get the flake,ugwpv1 and ras BLs created and then still run the verify step. |
* Add @gspetro-NOAA, @natalie-perlin, and @EdwardSnyder-NOAA to CODEOWNERS so they are notified of all PRs and can review them. * Remove duplicates in CODEOWNERS; remove users who will no longer be working with the repo.
ufs-community#757) doxygen changes for io/module_fv3_io_def.F90 and module_fv3_config.F90 --------- Co-authored-by: Jun Wang <jun.wang@noaa.gov>
5 participants
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Implements advanced snow physics in Icepack and CICE. Fixes history file issue when the initial time is not at hour 0. This is needed for the update to the coupled RT tests, which use an initial time of hour=6 since it impacts the history file timestamp.
Changes are required in
ice_into accommodate both the advanced snow physics as well as a renaming of the evp algorithm.Issue(s) addressed
See CICE issue #37 for a more complete description of changes.
Testing
All baselines for tests using CICE will change, even with the advanced snow physics option turned off.
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies