Skip to content

Bring AutoRT updates into develop#753

Merged
BrianCurtis-NOAA merged 46 commits into
ufs-community:developfrom
BrianCurtis-NOAA:feature/autort-bl
Aug 19, 2021
Merged

Bring AutoRT updates into develop#753
BrianCurtis-NOAA merged 46 commits into
ufs-community:developfrom
BrianCurtis-NOAA:feature/autort-bl

Conversation

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA commented Aug 19, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Description

This PR contains all the updates made to the Automated Regression Testing since the last commit involving the tests/auto directory

Testing

These changes were continually tested on a daily basis.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • CI

Dependencies

None

Linked Issue

Closes #752

BrianCurtis-NOAA and others added 30 commits March 28, 2021 18:10
@BrianCurtis-NOAA
Old repo went stale, trying fresh
dbd2b50
@BrianCurtis-NOAA
Check for BL_DATE in PR body BEFORE getting far into the Job
c7ca541
@BrianCurtis-NOAA
Raised error at wrong point in get_bl_date()
de8a812
@BrianCurtis-NOAA
BL JOBS PASSED: hera.gnu. Updated rt.sh with new develop date: 20210324
b68615f
@BrianCurtis-NOAA
change rt.sh to work for code
c91b9d6
@BrianCurtis-NOAA
Merge branch 'feature/autort-bl' of https://github.com/BrianCurtis-NO…
8c5cdf9 
…AA/ufs-weather-model into feature/autort-bl
@BrianCurtis-NOAA
Make logging better in update_rt_sh
4134be2
@BrianCurtis-NOAA
Lets not go through with the BL job if the directory already exists a…
1447195 
…s it should not before starting the job
@BrianCurtis-NOAA
BL JOBS PASSED: hera.gnu. Updated rt.sh with new develop date: 20210331
29f1944
@BrianCurtis-NOAA
Search for BL_DATE= not BL_DATE as the latter is not unique
58da308
@BrianCurtis-NOAA
need to test date that doesn't match code
a256db4
@BrianCurtis-NOAA
BL JOBS PASSED: hera.gnu. Updated rt.sh with new develop date: 20210331
7798cac
@BrianCurtis-NOAA
Adjusting to upstream date for test with RT
1168e41
@BrianCurtis-NOAA
RT JOBS PASSED: hera.gnu. Log file uploaded. skip-ci
2bce7e4
@BrianCurtis-NOAA
Reverting regression test log, and fixing hera directories for emc.ne…
7981107 
…mspara
@BrianCurtis-NOAA
Don't need to skip-ci any more
5df473d
@BrianCurtis-NOAA
Lets look in ufs-community and not BrianCurtis-NOAA for repo PR's
20634a5
@BrianCurtis-NOAA
Adjustments for GAEA and HERA
6297c15
@BrianCurtis-NOAA
Allow empty commit messages
3192ab0
@BrianCurtis-NOAA
Run RT job after successful BL Job
3a1daf7
@BrianCurtis-NOAA
Space issues from bad editor
7c6330a
@BrianCurtis-NOAA
Some fixes
4e68e6f
@BrianCurtis-NOAA
Fixes from Gaea tests
db102d0
@BrianCurtis-NOAA
Update to h-nems accouunt and storage locations on Jet
ff19c26
@BrianCurtis-NOAA
FAIL is not shown where baselines are there but jobs does not complet…
67eb9f3 
…e, thus changing search string to 'Test' and 'failed'
@BrianCurtis-NOAA
Merge from upstream/develop and conflict resolution
adddae3
@BrianCurtis-NOAA
test addition
e5a1b21 
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@BrianCurtis-NOAA
test subtraction
a6008f8 
on-behalf-of @ufs-community
@BrianCurtis-NOAA
Cheyenne Fixes
ddea93c
@BrianCurtis-NOAA
Need to fail nicely when PR owners block commits by maintainers
1e591a6
BrianCurtis-NOAA and others added 15 commits April 20, 2021 19:11
@BrianCurtis-NOAA
Merge branch 'feature/autort-bl' of https://github.com/BrianCurtis-NO…
89fb16c 
…AA/ufs-weather-model into feature/autort-bl
@BrianCurtis-NOAA
Merge branch 'develop' into feature/autort-bl
9d60073
@BrianCurtis-NOAA
Typo in RTBLDIR
d1e13a9
@BrianCurtis-NOAA
New autort location on cheyenne. lets note when baselines are complet…
0e9a294 
…ed in the PR comment if something fails later on
@BrianCurtis-NOAA
/glade/scratch/ not /glade/work
8e85cfc
@BrianCurtis-NOAA
remove f-string where no variables are
7f343ff 
remove f-string in comment text append
@BrianCurtis-NOAA
line had tab indentation instead of space
c01b725
@BrianCurtis-NOAA
Lets check to see if the baseline dir exists before running BL job
59ca5da
@BrianCurtis-NOAA
Add a comment to the PR text on BLDIR existing
f2533ae
@BrianCurtis-NOAA
job_obj needs to be added to call variables
0cf6bf3
@BrianCurtis-NOAA
Special case for orion to use adjust_permissions.sh
ad5b017
@BrianCurtis-NOAA
Merge branch 'feature/autort-bl' of https://github.com/BrianCurtis-NO…
0c11ec9 
…AA/ufs-weather-model into feature/autort-bl
@BrianCurtis-NOAA
Hera ECFLOW node adjustments
0d6539f
@BrianCurtis-NOAA
Merge branch 'feature/autort-bl' of https://github.com/BrianCurtis-NO…
e56a045 
…AA/ufs-weather-model into feature/autort-bl
@BrianCurtis-NOAA
Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…
af4e392 
…r-model into feature/autort-bl
@BrianCurtis-NOAA BrianCurtis-NOAA added enhancement New feature or request No Baseline Change No Baseline Change labels Aug 19, 2021
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator Author

BrianCurtis-NOAA commented Aug 19, 2021

Note: I have no intention to stop using BrianCurtis-NOAA:feature/autort-bl for the cronjobs etc. I think this is a good time to bring these updates into develop. It's been a while.

@climbfuji
Copy link
Copy Markdown
Collaborator

climbfuji commented Aug 19, 2021

@BrianCurtis-NOAA the updates in this PR is what is used by autoRT on all the platforms except wcoss, correct? If so, then I think we should merge this right away. No need to run regression tests, because the tests/auto/* files aren't used by anything else than autoRT.

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator Author

BrianCurtis-NOAA commented Aug 19, 2021

@BrianCurtis-NOAA the updates in this PR is what is used by autoRT on all the platforms except wcoss, correct? If so, then I think we should merge this right away. No need to run regression tests, because the tests/auto/* files aren't used by anything else than autoRT.

Correct. This is whats used currently on all platforms except WCOSS.

junwang-noaa
junwang-noaa approved these changes Aug 19, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@junwang-noaa junwang-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brian, thank you very much for bringing the code changes back to the develop branch.

@BrianCurtis-NOAA BrianCurtis-NOAA merged commit a957711 into ufs-community:develop Aug 19, 2021
@junwang-noaa junwang-noaa mentioned this pull request Nov 8, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@climbfuji climbfuji climbfuji approved these changes

@junwang-noaa junwang-noaa junwang-noaa approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request No Baseline Change No Baseline Change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bring AutoRT updates from BrianCurtis-NOAA:feature/autort-bl into develop

3 participants

@BrianCurtis-NOAA @climbfuji @junwang-noaa