Skip to content

Release/P7b: Bring in #623 with Mushy Thermodyn setting in RT#628

Merged
junwang-noaa merged 2 commits into
ufs-community:release/P7bfrom
junwang-noaa:mushy_setting
Jun 8, 2021
Merged

Release/P7b: Bring in #623 with Mushy Thermodyn setting in RT#628
junwang-noaa merged 2 commits into
ufs-community:release/P7bfrom
junwang-noaa:mushy_setting

Conversation

@junwang-noaa
Copy link
Copy Markdown
Collaborator

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

The PR brings in the code updates from #623 with Mushy Thermodyn setting in regression test, the changes are required for P7b for CICE6 update.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel

Dependencies

There is no dependencies for this PR

DeniseWorthen and others added 2 commits June 8, 2021 05:58
…#584) (ufs-community#623)


* make nems_frac the default CPLMODE
* make FRAC_GRID=true the default
* remove non-frac grid regression tests
* change wall clock for debugfrac. This test runs in less than ~5mins
* remove additional cpld_bmark and wave tests and their 35d versions
* reduce fhmax control_c384 to 12 hours
* add optional variables to turn on mushy thermo
@junwang-noaa junwang-noaa merged commit c9027ef into ufs-community:release/P7b Jun 8, 2021
@junwang-noaa junwang-noaa deleted the mushy_setting branch November 24, 2021 14:52
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
* Add RAVE data processing to fire_emission task

* turn off save options by default

* remove typo

* add file check to aqm_lbcs task

* update hash of upp
zhanglikate pushed a commit to zhanglikate/ufs-weather-model that referenced this pull request Oct 20, 2025
* add IFI to post

* pass w to model & fixes to ccpp/physics changes

* send lightning threat indexes to post

* upp: remove 444 ltng and add 704

* ccpp/physics: fill ltg*_max with 0 when model is hydrostatic

* atmos_cubed_sphere: only send w to model in non-hydrostatic mode, and only if model wants it

* disable lightning_threat when hydrostatic, and initialize wgrs

* turn off lightning_threat by default since it allocates wgrs and passes w

* missing `active = (lightning_threat_indices_enabled)` for wgrd

* UPP submodule: correct ifi load on acorn

* remove unneeded initialization of ltg*_max in post_fv3

* remove unneeded hydrostatic check from maximum_hourly_diagnostics

* fix out-of-bounds access in upp calslr_roebbr

* fix another out-of-bounds access and move a message to stdout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants