Move IO related configuration from fv3_cap to write grid component#600
Conversation
|
@rsdunlapiv I had to revert one commit (using semantic labels in fv3_cap) from this PR because cpld tests failed using GNU compilers on Hera and Cheyenne. We need to find out why. |
|
Machine: cheyenne |
|
Machine: gaea |
All tests except this one finished successfully. Since gaea.intel tests already passed in the previous commit, I'm not going to rerun this again. |
|
Ready for review/merge. |
* Enhanced stability of drag_suite module and added diagnostics * Updated standard_names for do_gsl_drag_ls_bl, do_gsl_drag_ss, do_gsl_drag_tofd and ugwp_seq_update * Assumed-shape in gwdps.f * Added logical flag 'ugwp_seq_update' to gfs_physics_nml namelist * Modified calculation of dtfac in drag_suite.F90 and revised various long_name's of diagnostic variables * Removed passage of variables 'ak' and 'bk' to drag_suite -- these are no longer used * Removed unused variables from GFS_typedefs.F90 and added clarifying comments in ccpp-physics
…provements (#600) This is another round of improvements for the pythonized WE2E test scripts. I was originally going to wait until the script was ready to replace, but I accidentally forgot to make a change to a final log message in monitor_jobs.py; this results in a scary-looking error message even though all experiments may have completed successfully. The solution was simply to replace the undefined variable with a correct one. This PR comes from an in-progress branch for improvements to the python scripts, so a few other improvements are coming along with this bug fix: * When monitor_jobs.py is called for the first time, it will check the status of all jobs, not just those that are incomplete. This will allow users to use this script to monitor a previously failed job that has been fixed. * Add checks for proper run_envir, and add all needed variables for run_envir=nco mode. * Fix another incorrect error message in setup.py.
6 participants
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Update fv3_cap's SetServices to use ONLY the semantic labels for each of the phases
Move IO related configuration from fv3_cap to write grid component
Code cleanup.
Is a change of answers expected from this PR? No.
Are any library updates included in this PR (modulefiles etc.)? No.
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs