Thompson subcycling for develop#595
Closed
climbfuji wants to merge 16 commits into
Closed
Conversation
This was referenced May 24, 2021
…r-model into thompson_subcycling_for_develop
DusanJovic-NOAA
approved these changes
May 26, 2021
junwang-noaa
approved these changes
May 26, 2021
climbfuji
force-pushed
the
thompson_subcycling_for_develop
branch
from
78d543d to
3f84c17
Compare
13 tasks
This was referenced Jun 9, 2021
Collaborator
Author
|
This PR was replaced with #632. |
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
zhanglikate
pushed a commit
to zhanglikate/ufs-weather-model
that referenced
this pull request
Oct 20, 2025
…-community#595) * Change the format of domain restart files to netcdf4 and set chunksizes * Remove nc_format="netcdf4" argument when opening restart files * Set chunksize of zaxis and time axis to 1 * Update clm_lake and rrfs_sd modules to support chunksizes * Make quilting restart files identical to fms files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Description
Implement a subcycling capability for Thompson MP in CCPP and exercise it in the UFS regression tests. This ufs-weather-model PR only updates the submodule pointer for fv3atm for the changes w.r.t. Thompson MP described in the associated PRs below.
Additional changes:
ufs_hera.gnu_debugcompile.shto copy the correct modulefile when DEBUG is usedThe changes to the suite FV3_GSD_noah/FV3_GFS_v16_thompspn (run Thompson MP with 4/2 subcycles) change the answer of several Thompson MP based regression tests. No new input data required.
Issue(s) addressed
Fixes #596
Testing
Preliminary regression testing on Hera with GNU and Intel against existing baseline (2021/05/26): all tests that are expected to pass do pass, and all tests that are expected to fail do fail with b4b mismatches (but they all run to completion):
rt_hera_gnu_verify_against_existing.log
rt_hera_gnu_verify_against_existing_fail_test.log
rt_hera_initel_verify_against_existing.log
rt_hera_initel_verify_against_existing_fail_test.log
Full regression tests will be run on all tier-1 platforms when it is time to commit.
Dependencies
NCAR/ccpp-physics#666
NCAR/ccpp-framework#376
NOAA-EMC/ufsatm#316
#595