ugwpv1_gsldrag bug fixes, and GFS_typdefs updates associated with diag flags for ugwpv1_gsldrag.F90 and GFS_DCNV_generic.F90#535
Closed
mdtoy wants to merge 1 commit into
Closed
ugwpv1_gsldrag bug fixes, and GFS_typdefs updates associated with diag flags for ugwpv1_gsldrag.F90 and GFS_DCNV_generic.F90#535mdtoy wants to merge 1 commit into
mdtoy wants to merge 1 commit into
Conversation
…g flags for ugwpv1_gsldrag and GFS_DCNV_generic.F90
Collaborator
|
This PR is no longer required, the submodule pointer updates for the changes in fv3atm and ccpp-physics will be handled in PR #541. |
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
RRFS requires certain observation files and data products to be retrieved & staged before the data processing and assimilation tasks are run. This work introduces some small changes to the retrieve_data.py script to allow retrieval/staging of local (machine-hosted; e.g.: Jet, Hera, noaacloud) and general, remotely located (extending beyond nomads/aws) files, primarily in the relaxation of/introduction of new parse_args function arguments. Minor updates to the data_locations.yaml are included here (more will follow), including the addition of RAP bufr files and GSI-fix files from NOAA AWS S3 buckets. FV3GFS & RAP bufr data stream locations on Jet and Hera have been added to the respective ush/machine YAMLS. --------- Co-authored-by: ulmononian <cameron_book@alummni.brown.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the final accumulation of tendencies at the end of subroutine ugwpv1_gsldrag_run in module ugwpv1_gsldrag.
Fixes inconsistencies between allocation of diagnostic variables in GFS_typedefs.F90 and ugwpv1_gsldrag.F90 as determined by logical flags.
Fixes inconsistencies between allocation of diagnostic variables in GFS_typedefs.F90 and GFS_DCNV_generic.F90 as determined by logical flags.