Skip to content

Port to stampede2 for XSEDE. skip-ci#463

Closed
MinsukJi-NOAA wants to merge 5 commits into
ufs-community:developfrom
MinsukJi-NOAA:feature/xsede-stampede
Closed

Port to stampede2 for XSEDE. skip-ci#463
MinsukJi-NOAA wants to merge 5 commits into
ufs-community:developfrom
MinsukJi-NOAA:feature/xsede-stampede

Conversation

@MinsukJi-NOAA
Copy link
Copy Markdown
Contributor

Description

Port to stampede2 for XSEDE users.

Issue(s) addressed

#460
NOAA-EMC/global-workflow#280

Testing

No testing is required.

On stampede2, the following regression tests have been built and run:

COMPILE | SUITES=FV3_GFS_2017_coupled,FV3_GFS_2017_satmedmf_coupled,FV3_GFS_v15p2_coupled,FV3_GFS_v16_coupled S2S=Y WW3=Y
RUN | cpld_bmark_wave
RUN | cpld_bmarkfrac_wave
RUN | cpld_bmarkfrac_wave_v16

Dependencies

No

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

Will we be maintaining a full baseline on Stampede?

@MinsukJi-NOAA
Copy link
Copy Markdown
Contributor Author

Will we be maintaining a full baseline on Stampede?

I strongly doubt that. The tests I did on Stampede were just completing the simulations, not comparing with baselines.

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

I see. But the use will be primarily Prototype-like runs by groups outside of EMC using a workflow. Is that right?

@MinsukJi-NOAA
Copy link
Copy Markdown
Contributor Author

@DeniseWorthen , that is my understanding.

@climbfuji
Copy link
Copy Markdown
Collaborator

@DeniseWorthen , that is my understanding.

I "ported" the ufs-weather-model to stampede twice in the past. If regression tests are not run, who makes sure that the code keeps working there? That didn't even work with Cheyenne, even when it was a tier-2 (post commit regression testing) platform.

@MinsukJi-NOAA
Copy link
Copy Markdown
Contributor Author

@climbfuji. Good point. As Denise mentioned, groups outside EMC will use the global workflow. Maybe any changes specific to stampede should be in the global-workflow repository? For sure, the changes in rt.sh and fv3_slurm.IN_stampede are not needed. I am not sure if modulefiles/stampede/fv3 is directly used by global workflow either (probably not).

@MinsukJi-NOAA MinsukJi-NOAA added the Waiting for Reviews The PR is waiting for reviews from associated component PR's. label Mar 16, 2021
@junwang-noaa junwang-noaa added the No Baseline Change No Baseline Change label Mar 16, 2021
Copy link
Copy Markdown
Collaborator

@junwang-noaa junwang-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me, assuming they were tested on stampede2.

@MinsukJi-NOAA
Copy link
Copy Markdown
Contributor Author

Changes merged in via #477. Thanks @DusanJovic-NOAA!

@MinsukJi-NOAA MinsukJi-NOAA deleted the feature/xsede-stampede branch March 24, 2021 14:38
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model that referenced this pull request Apr 4, 2023
*  Improve cloud fraction when using Thompson MP. See NCAR/ccpp-physics#809 for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No Baseline Change Waiting for Reviews The PR is waiting for reviews from associated component PR's.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants