Update WW3 for porting and threading issues #435
Closed
JessicaMeixner-NOAA wants to merge 8 commits into
Closed
Conversation
Collaborator
Author
|
Merged with the latest ufs-weather-model and also updated WW3 to the top of it's develop branch. hera.intel logs updated. This PR could be combined with another one, or whatever is most convenient. |
Conflicts: tests/RegressionTests_hera.intel.log
Collaborator
|
Merged in PR #383 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates WW3 to the latest develop branch, which has updates for threading (see Issue #367)
it also has updates for WW3 to be able to be build on gaea, jet and theoretically with gnu compilers although that has not been tested.
Issue(s) addressed
Testing
How were these changes tested? On hera
What compilers / HPCs was it tested with? intel
Are the changes covered by regression tests? No, tests should be added for testing WW3 thread safe and tests should be turned on for waves on other platforms. The WW3 thread safe test ran into an issue that we are having issues with the number of MPI tasks changing answers (Issue #427 ) which will be addressed in another PR. The code compiles on Gaea but I did not have access to an account that can run the tests (request has been submitted), so the tests were not turned on. Theoretically the code should be able to compile on jet now as well.
Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? hera.intel so far
Dependencies
The PR in WW3 is merged NOAA-EMC/WW3#315