Remove FMS from UFS MPAS Atmosphere#3201
Conversation
…grate over correct forecast interval.
…r-model into feature/mpas_lbc_plus_cleanup
…stinswales/ufs-weather-model into feature/mpas_lbc_plus_cleanup
|
It looks like please refer to the following on Ursa |
@FernandoAndrade-NOAA Sorry. There is no output at the initial time step. I updated the test files. |
Fix link
gspetro-NOAA
left a comment
There was a problem hiding this comment.
Several tests increased by 1 remark# 10448, which is the ifort deprecation remark. This will resolve with the move to spack-stack v2.1.x, so the PR can proceed despite the failing CI test.
Commit Queue Requirements:
test_changes.listindicates which tests, if any, are changed by this PR. Committest_changes.list, even if it is empty.Description
This PR removes all FMS dependencies in the MPAS enabled UFS.
For logging and error handling, we now use the MPAS native logging functionality.
ESMF has replaced FMS for clock management. Most of the FMS functionality is included with ESMF, so this was straightforward.
With the FMS removal, we had to create some new infrastructure to provide MPAS configurability. This was necessary since we relied on FMS for runtime configurability.
A new routine, ufs_mpas_read_stream_lists, allows for runtime control over which fields are included in the various MPAS output streams (e.g., output, restart, diag, etc...). This provides the same functionality of standalone MPAS.
Initial tracer/constituent handling. This replaces the FMS tracer_tables. This may be revamped in the future to handle constituents differently.
New, non-FMS, handling of the atmospheric namelist.
Other things (non-FMS related) included here:
Added new interval to write restart files at different interval than output files. These are controlled by the UFS model_configure file.
Adopted/modified shared UFS tool to control restart, and output, file frequency, shr_is_restart_fh_mod. This is used by other UFS components NUOPC caps. Thanks @NickSzapiro-NOAA
Output/restart file format now matches with standalone MPAS-A. Timestamp in file name was HH:MM:SS, changed to HH.MM.SS. This addresses #3209
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
N/A
Documentation:
N/A
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log:
Several tests increased by 1 remark# 10448, which is the ifort deprecation remark. This will resolve with the move to spack-stack v2.1.x.