Add MERRA2 aerosol three hourly forcing to drive UFS #2684
Add MERRA2 aerosol three hourly forcing to drive UFS #2684AnningCheng-NOAA wants to merge 23 commits into
Conversation
|
@AnningCheng-NOAA Could you push the tests/logs/RegressionTests_*.log from the machine where you ran your regression tests please? Also, there are some missing sections of this template that code managers need to see completed (checkboxes, description, commit messages, submodule PR links). |
|
Hi, Firl,
I have sync with the trunk and fix the issues. However, The trunk does not
pass compilation in hera
at /scratch1/NCEPDEV/stmp2/Anning.Cheng/FV3_RT/rt_3293852/compile_atm_dyn32_intel
with err related to bacio. Does anybody know how to fix this?
…On Fri, May 2, 2025 at 10:49 AM Grant Firl ***@***.***> wrote:
*grantfirl* left a comment (ufs-community/ufs-weather-model#2684)
<#2684 (comment)>
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> Could you push
the tests/logs/RegressionTests_*.log from the machine where you ran your
regression tests please? Also, there are some missing sections of this
template that code managers need to see completed (checkboxes, description,
commit messages, submodule PR links).
—
Reply to this email directly, view it on GitHub
<#2684 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIOLKJXG5N4F7WMYBAL24OAWJAVCNFSM6AAAAAB2UIWOMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNBXGM4TCMZTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I am able to compile the code and regression tests passed in Orion, still not know why the trunk does not pass compilation in hera. |
|
just pass regression tests in hera and push the log file. |
|
@AnningCheng-NOAA It looks like the regression test logs that you uploaded are only showing results for the new test ( |
|
Yes. Merra2_hf_thompson is the only test changing the baseline. I will
perform a fully RT soon.
…On Fri, May 16, 2025 at 11:56 AM Grant Firl ***@***.***> wrote:
*grantfirl* left a comment (ufs-community/ufs-weather-model#2684)
<#2684 (comment)>
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> It looks like the
regression test logs that you uploaded are only showing results for the new
test (merra2_hf_thompson). We actually need logs for the entire rt.conf
test suite, including your new test. I'm guessing that the only test that
should change results should be the merra2_hf_thompson test, right? If
so, the test_changes.list file should only contain that test.
—
Reply to this email directly, view it on GitHub
<#2684 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIOYCDBVTMEQ4TBMHMT26YDDNAVCNFSM6AAAAAB2UIWOMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBXGEYTKMJYGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@AnningCheng-NOAA can you sync up branch? so we can do a pre test to make sure. |
|
@jong Kim - NOAA Affiliate ***@***.***> done
…On Mon, May 19, 2025 at 2:41 PM JONG KIM ***@***.***> wrote:
*jkbk2004* left a comment (ufs-community/ufs-weather-model#2684)
<#2684 (comment)>
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> can you sync up
branch? so we can do a pre test to make sure.
—
Reply to this email directly, view it on GitHub
<#2684 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIMGQGGSRAK6BSJW2SL27IQUZAVCNFSM6AAAAAB2UIWOMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOJRHE3DAMRXHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@jkbk2004 Please make sure that the description is added and labels are added. Also please make sure the syncing of develop was done successfully (There are a lot of artifacts from improper code merges). Please let me know when Hera input-data has the new input data for this PR so I can sync it on WCOSS2. |
@jkbk2004 Ya, I see a bunch of little mistakes that have been committed. If you don't have time, I can try to clean up this PR. Let me know. |
|
@jkbk2004 It's also not clear to me that testing has been done correctly. Since this is a ccpp-physics-started PR, I can try to run full RTs and upload the right logs. Again, just let me know. |
|
Correct!
…On Mon, May 19, 2025 at 3:58 PM JONG KIM ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/fv3_conf/control_run.IN
<#2684 (comment)>
:
> for n in 01 02 03 04 05 06 07 08 09 10 11 12; do
cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/MERRA2_y14_24/merra2_1423_${n}.nc aeroclim.m${n}.nc
done
+fi
+if [ $IAER = 6011 ]; then
+ ln -sf /scratch1/NCEPDEV/climate/Anning.Cheng/MERRA2_40y/2021_03/MERRA2_400.inst3_3d_aer_Nv.20210322.nc4 merra2_20210322.nc
+ ln -sf /scratch1/NCEPDEV/climate/Anning.Cheng/MERRA2_40y/2021_03/MERRA2_400.inst3_3d_aer_Nv.20210323.nc4 merra2_20210323.nc
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> I rsynced the new
file ok on hera. This line can be update:
@[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/MERRA2_40y/2021_03/MERRA2_400.inst3_3d_aer_Nv.20210322.nc4
merra2_20210322.nc
—
Reply to this email directly, view it on GitHub
<#2684 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMINI23JWIFC6V3YJJFD27IZV5AVCNFSM6AAAAAB2UIWOMKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNJRHA2TMNJWGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@grantfirl it will be great if a full test can be run. Let me know if it's too busy on your side. |
|
@jkbk2004 @AnningCheng-NOAA I think that this is cleaned up now. I've started the full rt.conf on Hera and will push new logs when finished. |
|
@jkbk2004 @AnningCheng-NOAA There were many RT failures with this code. The failures that I checked on didn't even run because the |
|
@AnningCheng-NOAA If you want to look at the logs, etc., (on Hera) my test code is here: /scratch1/BMC/gmtb/Grant.Firl/ufs-weather-model-test/tests and the run directories are here: /scratch1/BMC/gmtb/Grant.Firl/stmp2/Grant.Firl/FV3_RT/rt_373056 I'm pretty confident that the problem is described in the previous comment though. |
|
@grant Firl - NOAA Affiliate ***@***.***> good catch! just pushed
the changes and made a full RT.
…On Tue, May 20, 2025 at 11:38 AM Grant Firl ***@***.***> wrote:
*grantfirl* left a comment (ufs-community/ufs-weather-model#2684)
<#2684 (comment)>
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> If you want to
look at the logs, etc., my test code is here:
/scratch1/BMC/gmtb/Grant.Firl/ufs-weather-model-test/tests and the run
directories are here:
/scratch1/BMC/gmtb/Grant.Firl/stmp2/Grant.Firl/FV3_RT/rt_373056
I'm pretty confident that the problem is described in the previous comment
though.
—
Reply to this email directly, view it on GitHub
<#2684 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMILQR5GS4UO7LEUMYXT27NEAXAVCNFSM6AAAAAB2UIWOMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOJUHEZDGNZYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@AnningCheng-NOAA I pushed the test_changes.list and the RT log from Hera for all tests. In addition to the new test that you added, the other tests that set All other tests pass. |
|
@grantfirl, the other two with mraerosol=T should not change the baseline.
I am taking a look at it now.
…On Thu, May 22, 2025 at 10:44 AM Grant Firl ***@***.***> wrote:
*grantfirl* left a comment (ufs-community/ufs-weather-model#2684)
<#2684 (comment)>
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> I pushed the
test_changes.list and the RT log from Hera for all tests. In addition to
the new test that you added, the other tests that set mraerosol to True
are also changing results. Is this expected?
All other tests pass.
—
Reply to this email directly, view it on GitHub
<#2684 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMINPZSO3VO4AO3SSAWD27XPCXAVCNFSM6AAAAAB2UIWOMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMBRGUYDANBYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@grant Firl - NOAA Affiliate ***@***.***> I just found that all
baselines with mraerosol=T should change baseline. The reason is that the
mraerosol=T is not passed into input.nml in the current RT tests, for
example, /scratch1/NCEPDEV/stmp2/Anning.Cheng/FV3_RT/rt_1936005/merra2_thompson_intel/input.nml
Our new tests, however, with mraerosol passed
in: /scratch1/NCEPDEV/stmp2/Anning.Cheng/FV3_RT/rt_444761/merra2_thompson_intel/input.nml
On Thu, May 22, 2025 at 1:22 PM Anning Cheng - NOAA Affiliate <
***@***.***> wrote:
… @grantfirl, the other two with mraerosol=T should not change the baseline.
I am taking a look at it now.
On Thu, May 22, 2025 at 10:44 AM Grant Firl ***@***.***>
wrote:
> *grantfirl* left a comment (ufs-community/ufs-weather-model#2684)
> <#2684 (comment)>
>
> @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> I pushed the
> test_changes.list and the RT log from Hera for all tests. In addition to
> the new test that you added, the other tests that set mraerosol to True
> are also changing results. Is this expected?
>
> All other tests pass.
>
> —
> Reply to this email directly, view it on GitHub
> <#2684 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALQPMINPZSO3VO4AO3SSAWD27XPCXAVCNFSM6AAAAAB2UIWOMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMBRGUYDANBYGU>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
@jkbk2004 This can go after the GFSv17 high priority PRs. |
|
Don't @ me |
|
@AnningCheng-NOAA can you sync up branches? we can start working on this pr. |
@jkbk2004 @AnningCheng-NOAA I'll do that. |
|
Thanks @grant Firl - NOAA Affiliate ***@***.***>
…On Thu, Jul 17, 2025 at 12:29 PM Grant Firl ***@***.***> wrote:
*grantfirl* left a comment (ufs-community/ufs-weather-model#2684)
<#2684 (comment)>
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> can you sync up
branches? we can start working on this pr.
@jkbk2004 <https://github.com/jkbk2004> @AnningCheng-NOAA
<https://github.com/AnningCheng-NOAA> I'll do that.
—
Reply to this email directly, view it on GitHub
<#2684 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIOKDU6CHJN5HWQQ7CD3I7FOVAVCNFSM6AAAAAB2UIWOMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOBUGY4TEMRYGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@grantfirl Sure! Please, go ahead to combine them. |
OK, the combo has been created: #2813 |
|
merged with #2813 |
5 participants
Commit Queue Requirements:
Description:
Commit Message:
Priority:
Git Tracking
Sub component Pull Requests:
#2683
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
No new library needed
Testing Log: