Skip to content

CMake Atmosphere Dycore Generalization + Fix for JEDI cubed sphere grid #2708#2604

Merged
jkbk2004 merged 20 commits into
ufs-community:developfrom
scrasmussen:fv3atm-cmake-generalization-0214
Apr 23, 2025
Merged

CMake Atmosphere Dycore Generalization + Fix for JEDI cubed sphere grid #2708#2604
jkbk2004 merged 20 commits into
ufs-community:developfrom
scrasmussen:fv3atm-cmake-generalization-0214

Conversation

@scrasmussen
Copy link
Copy Markdown
Collaborator

@scrasmussen scrasmussen commented Feb 14, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Changes from @dustinswales and @scrasmussen.

  • This PR reorganizes the project directory structure to allow multiple dycores. It isolates the FV3 dycore.
  • Variable name changes follow the pattern of fv3atm -> ufsatm, fv3atm -> ufsatm_fv3
  • This work was done to allow the imminent addition of the MPAS dycore and other dycores in the future.

Commit Message:

* UFSWM:
  * reorganize project structure to allow multiple dycores. Isolate FV3 dycore. cmake-atmosphere-generalization branch. Reorganize project structure to allow multiple dycores.
  * Fix for JEDI cubed sphere grid.
* FV3:
  * Reorganize project structure to allow multiple dycores. Isolate FV3 dycore. Some more reorganization to isolate the FV3 dycore coupling.
  * Fix for JEDI cubed sphere grid.

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes. RT log is on Hera at /scratch1/BMC/gmtb/Dustin.Swales/UFS/MPAS/soren/fv3atm-cmake-generalization-0206/tests/logs/RegressionTests_hera.log. I don't have access to Hera to commit test_changes.list

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@scrasmussen scrasmussen force-pushed the fv3atm-cmake-generalization-0214 branch from 5c8ca5e to 76064ea Compare February 19, 2025 23:36
@scrasmussen scrasmussen marked this pull request as ready for review February 19, 2025 23:38
@scrasmussen scrasmussen force-pushed the fv3atm-cmake-generalization-0214 branch from 76064ea to ebe4345 Compare February 27, 2025 00:18
@scrasmussen scrasmussen force-pushed the fv3atm-cmake-generalization-0214 branch from ebe4345 to b288fad Compare March 19, 2025 19:49
@scrasmussen scrasmussen force-pushed the fv3atm-cmake-generalization-0214 branch from b288fad to 7de8851 Compare April 11, 2025 15:11
scrasmussen and others added 2 commits April 11, 2025 09:13
…FV3 dycore.

Co-authored-by: dustinswales <dustinswales@users.noreply.github.com>
…to allow multiple dycores

Co-authored-by: dustinswales <dustinswales@users.noreply.github.com>
@scrasmussen scrasmussen force-pushed the fv3atm-cmake-generalization-0214 branch from 7de8851 to ce65665 Compare April 11, 2025 15:13
@jkbk2004 jkbk2004 mentioned this pull request Apr 18, 2025
14 tasks
@jkbk2004
Copy link
Copy Markdown
Collaborator

@scrasmussen can you sync up branches?

@grantfirl
Copy link
Copy Markdown
Collaborator

@scrasmussen can you sync up branches?

@jkbk2004 @scrasmussen I synced up these branches for him. This should be ready to test, I think.

@jkbk2004 jkbk2004 changed the title CMake Atmosphere Dycore Generalization CMake Atmosphere Dycore Generalization + Fix for JEDI cubed sphere grid #2708 Apr 22, 2025
@jkbk2004 jkbk2004 added the No Baseline Change No Baseline Change label Apr 22, 2025
@jkbk2004 jkbk2004 added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ort run ORT testing labels Apr 22, 2025
@BrianCurtis-NOAA BrianCurtis-NOAA added the In Testing The PR that is currently in testing stages label Apr 22, 2025
 on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@jkbk2004 jkbk2004 removed jenkins-ort run ORT testing In Testing The PR that is currently in testing stages labels Apr 23, 2025
@jkbk2004
Copy link
Copy Markdown
Collaborator

We can start merging process.

jkbk2004
jkbk2004 previously approved these changes Apr 23, 2025
dpsarmie
dpsarmie previously approved these changes Apr 23, 2025
 on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@jkbk2004 jkbk2004 merged commit 4a56620 into ufs-community:develop Apr 23, 2025
4 checks passed
@jkbk2004 jkbk2004 mentioned this pull request Apr 23, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update FV3ATM Cmakelists

7 participants