CMake Atmosphere Dycore Generalization + Fix for JEDI cubed sphere grid #2708#2604
Merged
jkbk2004 merged 20 commits intoApr 23, 2025
Merged
Conversation
5c8ca5e to
76064ea
Compare
76064ea to
ebe4345
Compare
ebe4345 to
b288fad
Compare
b288fad to
7de8851
Compare
…FV3 dycore. Co-authored-by: dustinswales <dustinswales@users.noreply.github.com>
…to allow multiple dycores Co-authored-by: dustinswales <dustinswales@users.noreply.github.com>
7de8851 to
ce65665
Compare
14 tasks
Collaborator
|
@scrasmussen can you sync up branches? |
Collaborator
@jkbk2004 @scrasmussen I synced up these branches for him. This should be ready to test, I think. |
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
Collaborator
|
We can start merging process. |
jkbk2004
previously approved these changes
Apr 23, 2025
BrianCurtis-NOAA
previously approved these changes
Apr 23, 2025
dpsarmie
previously approved these changes
Apr 23, 2025
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
b149837
jkbk2004
approved these changes
Apr 23, 2025
FernandoAndrade-NOAA
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
Description:
Changes from @dustinswales and @scrasmussen.
fv3atm -> ufsatm,fv3atm -> ufsatm_fv3Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
/scratch1/BMC/gmtb/Dustin.Swales/UFS/MPAS/soren/fv3atm-cmake-generalization-0206/tests/logs/RegressionTests_hera.log.I don't have access to Hera to committest_changes.listInput data Changes:
Library Changes/Upgrades:
Testing Log: