Skip to content

Tempo implementation#2590

Closed
AndersJensen-NOAA wants to merge 20 commits into
ufs-community:developfrom
AndersJensen-NOAA:tempo_dev
Closed

Tempo implementation#2590
AndersJensen-NOAA wants to merge 20 commits into
ufs-community:developfrom
AndersJensen-NOAA:tempo_dev

Conversation

@AndersJensen-NOAA
Copy link
Copy Markdown
Contributor

@AndersJensen-NOAA AndersJensen-NOAA commented Feb 4, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR implements TEMPO microphysics into the CCPP and UFS. TEMPO microphysics is the Thompson-Eidhammer Microphysics Parameterization for Operations. TEMPO lives in a submodule and is also connected to a version of MPAS run and maintained by GSL. Work in progress to connect TEMPO to WRF. The goal of TEMPO is to help unify microphysics and microphysics development across UFS applications and dynamical cores. TEMPO includes several options including aerosol-aware microphysics (https://doi.org/10.1175/JAS-D-13-0305.1 ) and 2-moment graupel with predicted density, or hail-aware microphysics (https://doi.org/10.1175/MWR-D-21-0319.1).

tempo is called with imp_physics = 88

TEMPO lives here:
https://github.com/NCAR/TEMPO

PR to CCPP
ufs-community/ccpp-physics#250

PR TO FV3
NOAA-EMC/ufsatm#922

Testing logs: /scratch2/BMC/wrfruc/jensen/git-local/UFS-TEMPO/tests/logs/log_hera

Commit Message:

* UFSWM - Adds regression tests
  * FV3 - Adds variables to typedefs and suite definition file. 
    * ccpp-physics - Connects TEMPO and TEMPO drivers and meta-data files.

Priority:

  • High: Reason - TEMPO is planned for use in an atmospheric-river forecast system.

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

TEMPO lives here:
https://github.com/NCAR/TEMPO

PR to CCPP
ufs-community/ccpp-physics#250

PR TO FV3
NOAA-EMC/ufsatm#922

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.

Input data Changes:

  • New input data.
    New lookup tables for TEMPO are needed.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@AndersJensen-NOAA AndersJensen-NOAA marked this pull request as ready for review February 4, 2025 17:06
Comment thread tests/rt.conf
RUN | control_p8 | - noaacloud | baseline |
RUN | control_p8.v2.sfc | - noaacloud | baseline |
RUN | control_p8_ugwpv1 | - noaacloud | baseline |
RUN | control_p8_ugwpv1_tempo | - noaacloud | baseline |
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndersJensen-NOAA These new RTs are failing because the new suite "FV3_GFS_v17_p8_ugwpv1_tempo" is not being compiled above in this file. I'll fix this.

@grantfirl
Copy link
Copy Markdown
Collaborator

FYI, the logs committed in 4e337cc show that all tests except the new TEMPO tests pass. I'm going to re-run the TEMPO tests individually to not have to re-do the rest of the tests and save some compute cycles. I'll post the new logs for the TEMPO tests in the comments.

@grantfirl
Copy link
Copy Markdown
Collaborator

For control_p8_ugwpv1_tempo:
RegressionTests_hera.log

@grantfirl
Copy link
Copy Markdown
Collaborator

For control_p8_ugwpv1_tempo_aerosol:
RegressionTests_hera.log

@grantfirl
Copy link
Copy Markdown
Collaborator

For control_p8_ugwpv1_tempo_aerosol_hail:
RegressionTests_hera.log

@AndersJensen-NOAA
Copy link
Copy Markdown
Contributor Author

AndersJensen-NOAA commented Mar 28, 2025

FYI, the logs committed in 4e337cc show that all tests except the new TEMPO tests pass. I'm going to re-run the TEMPO tests individually to not have to re-do the rest of the tests and save some compute cycles. I'll post the new logs for the TEMPO tests in the comments.

@grantfirl It is okay that they fail since there are no baseline tests, correct?

@grantfirl
Copy link
Copy Markdown
Collaborator

FYI, the logs committed in 4e337cc show that all tests except the new TEMPO tests pass. I'm going to re-run the TEMPO tests individually to not have to re-do the rest of the tests and save some compute cycles. I'll post the new logs for the TEMPO tests in the comments.

@grantfirl It is okay that they fail since there are no baseline tests, correct?

@AndersJensen-NOAA They weren't running because the new suite wasn't being compiled as part of rt.conf. I fixed this in 66294e5, so they're running fine now. They still appear as RT failures at this point because they're missing baselines though.

@dustinswales
Copy link
Copy Markdown
Collaborator

Combined with #2503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants