FV3 CCPP: wet() bug fix and workaround for bad tsfco#2572
Closed
SamuelTrahanNOAA wants to merge 3 commits into
Closed
FV3 CCPP: wet() bug fix and workaround for bad tsfco#2572SamuelTrahanNOAA wants to merge 3 commits into
SamuelTrahanNOAA wants to merge 3 commits into
Conversation
14 tasks
3 tasks
jkbk2004
pushed a commit
that referenced
this pull request
Feb 12, 2025
… fix and workaround for bad tsfco #2572 (#2529) * UFSWM - Provides a set of changes changes needed to take advantage of FMS parallel IO changes; adds a new diagnostic, instantaneous downward shortwave flux at the surface assuming clear-sky conditions * FV3 - Provides a set of changes changes needed to take advantage of FMS parallel IO changes; adds a new diagnostic, instantaneous downward shortwave flux at the surface assuming clear-sky conditions * ccpp-physics - adds a new diagnostic, instantaneous downward shortwave flux at the surface assuming clear-sky conditions * ccpp-physics - wet() bug fix and workaround for bad tsfco * atmos_cubed_sphere - Provides a set of changes changes needed to take advantage of FMS parallel IO changes --------- Co-authored-by: Samuel Trahan <samuel.trahan@noaa.gov>
Collaborator
|
merged with #2529 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
Derecho/HerculesDescription:
Fixes this problem:
It was caused by missing values (-1e+20) for sea surface temperature on
wetpoints in input data. (Wetpoints are points where the CCPPwetarray is true, thus indicating the surface is at least partly water.) There's a bug fix and a workaround:wetarray can be mistakenly true when it should be false due to the location being 100% ice. An "else" statement corrects this.wetpoint, the lowest model level temperature is used instead.There is no other temperature available on those points that can reasonably be used as a sea surface temperature. The lowest model level temperature may not be a perfect analogue for the sea surface temperature, but it'll be more realistic than -1E+20 K.
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: