Remove Expanse/Odin/Stampede & Update Orion/Hercules lmod init script location

[gspetro-NOAA]

Description:

This PR:

• Removes outdated modulefiles for Expanse, Stampede, and Odin.
• Removes related code from scripts.
• Updates the location of the Orion/Hercules lmod init script.

Ran RTs successfully on Hera. Log file here: /scratch2/NAGAPE/epic/Gillian.Petro/PR2570/ufs-weather-model/tests/logs/RegressionTests_hera.log

Commit Message:

* UFSWM - Rm Expanse/Stampede/Odin & update Orion/Hercules lmod init location

Priority:

• Normal

Git Tracking

UFSWM:

• Closes Orion lmod init script is incorrect in tests/module-setup.sh #2384
• Closes Remove unmaintained modulefiles #2280
• Closes rt.sh failure on Frontera #2539

Sub component Pull Requests:

• None

UFSWM Blocking Dependencies:

• None

---

Changes

Regression Test Changes (Please commit test_changes.list):

• No Baseline Changes.

Input data Changes:

• None.

Library Changes/Upgrades:

• No Updates

---

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • GaeaC5
  • GaeaC6
  • Derecho
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[gspetro-NOAA]

@uturuncoglu I made the update requested in Issue #2539 for Frontera. Can you check whether it still works as expected?

[uturuncoglu]

@gspetro-NOAA Thank you. Let me check it on Frontera. I'll update you.

[uturuncoglu]

@gspetro-NOAA It seem that this is working fine on Frontera. When I was trying to merge your branch with the head of UFS Coastal development, I noticed is that you have no section for Frontera in tests/default_vars.sh but I have something like following,

elif [[ ${MACHINE_ID} = frontera ]]; then 
  TPN=56

I don't have detailed numbers for Frontera (since I have no experience how those defined) like other platforms but you might also want to add that. Since Frontera is supported platforms at least these changes allow us to run UFS Coastal specific RTs.

I also have following for stampede and frontera in rt.sh. I am not sure about the stampede part but we are using frontera part under UFS Coastal.

  stampede)
    echo "rt.sh: Setting up stampede..."
    export PYTHONPATH=
    if [[ "${ECFLOW:-false}" == true ]] ; then
      ECFLOW_START=
    fi
    QUEUE=skx-normal
    COMPILE_QUEUE=skx-dev
    PARTITION=
    dprefix="${SCRATCH}/ufs-weather-model/run"
    DISKNM="/work2/07736/minsukji/stampede2/ufs-weather-model/RT"
    STMP="${dprefix}"
    PTMP="${dprefix}"
    SCHEDULER="slurm"
    export MPIEXEC="ibrun"
    export MPIEXECOPTS=
    ;;
  frontera)
    echo "rt.sh: Setting up frontera..."
    set -x
    export PYTHONPATH=
    if [[ "${ECFLOW:-false}" == true ]] ; then
      ECFLOW_START=
    fi
    QUEUE=development
    COMPILE_QUEUE=development
    PARTITION=
    dprefix="${SCRATCH}/frontera"
    DISKNM="/work2/01118/tg803972/frontera/RT"
    STMP=${dprefix}
    PTMP=${dprefix}
    SCHEDULER=slurm
    export MPIEXEC="ibrun"
    export MPIEXECOPTS=
    ;;

So, maybe that one could be added to rt.sh. It is totally up to you since we have those in our official UFS WM fork. Thanks again for your help.

[jkbk2004]

merged with #2569

[gspetro-NOAA]

@gspetro-NOAA It seem that this is working fine on Frontera. When I was trying to merge your branch with the head of UFS Coastal development, I noticed is that you have no section for Frontera in tests/default_vars.sh but I have something like following,

elif [[ ${MACHINE_ID} = frontera ]]; then 
  TPN=56

I don't have detailed numbers for Frontera (since I have no experience how those defined) like other platforms but you might also want to add that. Since Frontera is supported platforms at least these changes allow us to run UFS Coastal specific RTs.

I also have following for stampede and frontera in rt.sh. I am not sure about the stampede part but we are using frontera part under UFS Coastal.

  stampede)
    echo "rt.sh: Setting up stampede..."
    export PYTHONPATH=
    if [[ "${ECFLOW:-false}" == true ]] ; then
      ECFLOW_START=
    fi
    QUEUE=skx-normal
    COMPILE_QUEUE=skx-dev
    PARTITION=
    dprefix="${SCRATCH}/ufs-weather-model/run"
    DISKNM="/work2/07736/minsukji/stampede2/ufs-weather-model/RT"
    STMP="${dprefix}"
    PTMP="${dprefix}"
    SCHEDULER="slurm"
    export MPIEXEC="ibrun"
    export MPIEXECOPTS=
    ;;
  frontera)
    echo "rt.sh: Setting up frontera..."
    set -x
    export PYTHONPATH=
    if [[ "${ECFLOW:-false}" == true ]] ; then
      ECFLOW_START=
    fi
    QUEUE=development
    COMPILE_QUEUE=development
    PARTITION=
    dprefix="${SCRATCH}/frontera"
    DISKNM="/work2/01118/tg803972/frontera/RT"
    STMP=${dprefix}
    PTMP=${dprefix}
    SCHEDULER=slurm
    export MPIEXEC="ibrun"
    export MPIEXECOPTS=
    ;;

So, maybe that one could be added to rt.sh. It is totally up to you since we have those in our official UFS WM fork. Thanks again for your help.

@uturuncoglu I will create an issue for this and add it in my next PR, along with some other items we've discussed in different issues. Seemed simpler not to do it for this PR, but I'll add it soon.