Submodule pointer update (fv3atm, ccpp-framework) for ccpp-framework PR 600 (bug fix for unit conversion error in ccpp_prebuild.py )#2464
Closed
climbfuji wants to merge 2 commits into
Conversation
This was referenced Oct 11, 2024
Collaborator
Author
|
@DusanJovic-NOAA This won't be needed because you are pointing to my ccpp-framework branch, correct? |
jkbk2004
pushed a commit
that referenced
this pull request
Oct 23, 2024
…ccpp-framework) for ccpp-framework PR 600 (bug fix for unit conversion error in ccpp_prebuild.py ) #2464 + Update chunksizes for cubed sphere grid #2465 (#2463) * UFSWM - Update LND I/O docs Add fd_ufs.yaml docs Add tests-dev docs * UFSWM - Change the default chunking for the cubed sphere history files to use only the horizontal grid size of each of the tiles. * FV3 - Change the default chunking for the cubed sphere history files to use only the horizontal grid size of each of the tiles. * FV3 - Submodule pointer update for ccpp-framework PR 600 (bug fix for unit conversion error in ccpp_prebuild.py) --------- Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov> Co-authored-by: Dom Heinzeller <dom.heinzeller@ucar.edu>
Collaborator
|
merged with #2463 |
tsga
added a commit
to tsga/ufs-weather-model
that referenced
this pull request
Oct 30, 2024
* develop: [develop]: Documentation updates + Submodule pointer update (fv3atm, ccpp-framework) for ccpp-framework PR 600 (bug fix for unit conversion error in ccpp_prebuild.py ) ufs-community#2464 + Update chunksizes for cubed sphere grid ufs-community#2465 (ufs-community#2463) First reconciliation PR from production/RRFS.v1 (ufs-community#2449) Add GFDL Land Model 4.0 (ufs-community#2146)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
Description:
This PR updates the submodule pointer for fv3atm and ccpp-framework for the changes described in NCAR/ccpp-framework#600 (Bug fix for unit conversion error in ccpp_prebuild.py (variables that are slices of a n+1 dimensional array have wrong allocation). There are no code changes in fv3atm or ufs-weather-model. The bug that is being fixed did not affect the UFS Weather Model, hence there are no answer changes associated with this update. However, because the variable declaration for interface variables in the auto-generated CCPP caps changed slightly, I ran the full regression tests on Hera - all b4b.
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: