Skip to content

initialize scalar field when created for non-CSG (cube-sphere grid) components#2370

Merged
zach1221 merged 22 commits into
ufs-community:developfrom
DeniseWorthen:bugfix/initcplscalars
Aug 6, 2024
Merged

initialize scalar field when created for non-CSG (cube-sphere grid) components#2370
zach1221 merged 22 commits into
ufs-community:developfrom
DeniseWorthen:bugfix/initcplscalars

Conversation

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@DeniseWorthen DeniseWorthen commented Jul 17, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Initializes the scalar field when created for MOM6, CICE and WW3.

Commit Message:

* UFSWM - 
  * CICE - initialize scalar field when created
  * MOM6 - initialize scalar field when created
  * WW3 - initialize scalar field when created

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.

The cpld_debug_gfsv17_intel baseline on derecho will need to be created. A test baseline using this PR was created and was B4B on re-run.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@DeniseWorthen DeniseWorthen marked this pull request as ready for review July 17, 2024 22:59
@DeniseWorthen
Copy link
Copy Markdown
Collaborator Author

The test_changes.list was empty, so I couldn't commit it (shows no diff w/ previous file).

@DeniseWorthen DeniseWorthen changed the title initialize scalar field when created for non-CSG components initialize scalar field when created for non-CSG (cube-sphere grid) components Jul 30, 2024
@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Aug 2, 2024

@zach1221 @FernandoAndrade-NOAA can we check if derecho is available for a quick pre-test? If we have resource issue on derecho, I suggest to move to #2375 and prepare.

@zach1221
Copy link
Copy Markdown
Collaborator

zach1221 commented Aug 2, 2024

@zach1221 @FernandoAndrade-NOAA can we check if derecho is available for a quick pre-test? If we have resource issue on derecho, I suggest to move to #2375 and prepare.

I'm running on derecho now and the jobs are submitting ok so far.

@zach1221 zach1221 added Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Aug 5, 2024
@jiandewang
Copy link
Copy Markdown
Collaborator

I am not in front of computer at this moment, will do MOM merging around 9:30pm tonight

@jiandewang
Copy link
Copy Markdown
Collaborator

just merged MOM6, hash # 4b8777eb

@zach1221 zach1221 merged commit 74abf0f into ufs-community:develop Aug 6, 2024
@DeniseWorthen DeniseWorthen self-assigned this Feb 22, 2025
@DeniseWorthen DeniseWorthen deleted the bugfix/initcplscalars branch April 2, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cpl_scalar fields should be initialized in non-CSG components when created cpld_debug_gfsv17_intel failure on Derecho in the PR 2324

6 participants