Langmuir turbulence parameterization for WW3#2188
Closed
MatthewMasarik-NOAA wants to merge 8 commits into
Closed
Conversation
…aram * origin/develop: Remove compiler warnings for CMEPS and CICE; Add traditional threading templates for global apps and append _esmf for templates using ESMF-managed threading (was ufs-community#2179) (ufs-community#2172)
…e/Langmuir-param * mtm/feature/Langmuir-param:
Collaborator
Author
|
I'm going to close this draft PR in favor of opening a new one from a branch with a cleaned up commit history. I made a misstep somewhere along the way committing test_changes.list and syncing yesterday. Starting with a clean branch seemed preferable to me than trying to make fixes on top of this one. |
Collaborator
Author
|
New draft pr: #2195 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
Description:
Adds Langmuir turbulence parameterization from ESCOMP to allow computing Stokes drift diagnostics within the WW3 sub-component.
Commit Message:
Add Langmuir turbulence parameterization for computing Stokes drift diagnostics
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
(
mod_def's have been updated for all RT's. Updated directory location:/scratch1/NCEPDEV/climate/Matthew.Masarik/waves/share/ufs/moddefs/WW3_input_data_20240214).Library Changes/Upgrades:
Testing Log: