Remove nfhout, nfhmax_hf, nfhout_hf etc configuration parameters#2040
Closed
DusanJovic-NOAA wants to merge 8 commits into
Closed
Remove nfhout, nfhmax_hf, nfhout_hf etc configuration parameters#2040DusanJovic-NOAA wants to merge 8 commits into
DusanJovic-NOAA wants to merge 8 commits into
Conversation
35 tasks
SamuelTrahanNOAA
added a commit
to SamuelTrahanNOAA/ufs-weather-model
that referenced
this pull request
Dec 18, 2023
…figuration parameters
Merged
35 tasks
zach1221
pushed a commit
that referenced
this pull request
Dec 19, 2023
… AND #2040 and #2043 (#2041) General clean-up, and CCPP concurrency bug fixes 1. Remove nfhout, nfhmax_hf, nfhout_hf and nsout from fv3atm and the regression tests. ( Remove nfhout, nfhmax_hf, nfhout_hf etc configuration parameters NOAA-EMC/ufsatm#731 ) 2. Add comments to smc pert and fix bug in stc pert ( Fix bugs in soil temperature perturbation #2042 ) 3. Disable concurrency in NetCDF calls within CCPP GFS_phys_time_vary_init subroutine to avoid crashes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Author Checklist:
Description
Remove nfhout, nfhmax_hf, nfhout_hf and nsout model_configure parameters. The 'output_fh" is now used to control frequency of the history outputs.
Remove unused wave configuration parameters from ufs.configure templates
Commit Message
Linked Issues and Pull Requests
Associated UFSWM Issue to close
Subcomponent Pull Requests
Blocking Dependencies
Subcomponents involved:
Anticipated Changes
Input data
Regression Tests:
Tests effected by changes in this PR:
Libraries
Code Managers Log
Testing Log: