add component defaults, rename templates to .in, rename ufs.configure for application, cleanup tests#2010
Merged
zach1221 merged 32 commits intoDec 11, 2023
Conversation
* clean up unnecessary quotes in tests
* shared namelist requires mom6 variables to be set
* remove orbital variables from atm-land case since these are used only for the ocean albedo calculation * move use_coldstart and use_mommesh to OCN attributes in config.in files since these are only used by mom6, removed from hafs cases *remove mediator_read_restart since this is not used by ufs *add some variables to tests where needed
…ture/templates_and_defaults
42 tasks
* data component tests use mix of input directory names, switch them all to just INPUT
* use CICE_,MOM6_,WW3_ prefixes for configurable items
* see issue 2015
* multigrid is never used for cmeps coupled applications but required for run_test.sh
aerorahul
previously approved these changes
Dec 2, 2023
Contributor
aerorahul
left a comment
There was a problem hiding this comment.
Thanks for the additional templating of the configuration files.
The changes look good.
MatthewMasarik-NOAA
approved these changes
Dec 4, 2023
Collaborator
MatthewMasarik-NOAA
left a comment
There was a problem hiding this comment.
WW3 updates look good to me.
Collaborator
|
Jenkins-ci ORTs passed |
Collaborator
Author
|
Just noting that the hercules log shows a clean test because I turned off the troublesome |
Collaborator
|
Testing is complete, sending out final reviews. |
jkbk2004
approved these changes
Dec 11, 2023
sadeghitabas
approved these changes
Dec 11, 2023
NickSzapiro-NOAA
added a commit
to NickSzapiro-NOAA/ufs-weather-model
that referenced
this pull request
Dec 11, 2023
Following ufs-community#2010
NickSzapiro-NOAA
added a commit
to NickSzapiro-NOAA/ufs-weather-model
that referenced
this pull request
Dec 11, 2023
42 tasks
14 tasks
This was referenced Dec 29, 2023
41 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Author Checklist:
Description
Renames various
templatefiles for the coupled model to be.INfilesProvides component defaults for cice, mom6, cmeps and ww3 that can be re-used among applications instead of repeating the same defaults for each application
Renames
ufs.configurefiles using the application (ie, s2s, s2swa) which uses themAdds
CICE_,MOM6_andWW3_prefixes to many, but not all, configurable variablesAdds additional configuration settings for CICE,MOM6,CMEPS restart and output directories
Moves
use_coldstartanduse_mommeshfrom the ALLComp to the OCN attributes, since these are used only by MOM6Moves
eps_imeshfrom the ALLComp to the ICE attributes since this is used only by ICE. Note MOM6 has a similar setting (eps_omesh) which is configured w/ a default value via MOM_input.gives MOM6 and CICE their own mesh file setting instead of
meshiceocnsince in upcoming configurations (regional MOM6, FVCOM etc) the ocean will not run with the ice model presentUses
INPUTas input directory for all tests using CDEPS instead of various combinations ofINPUT_DATM,DATM_INPUT,INPUT_DOCNetcremoves unnecessary quotes in tests
turns off
control_wrtGauss_netcdf_parallel_inteltest on hercules. See Issue multiple netcdf_parallel tests fail on hercules #2015Linked Issues and Pull Requests
Associated UFSWM Issue to close
Subcomponent Pull Requests
Blocking Dependencies
Subcomponents involved:
Anticipated Changes
Input data
Regression Tests:
Three tests fail but run to completion:
These tests fail only because the filename stored in a file has a changed directory name, ie
INPUT/sst.day.mean.2019.ncvsINPUT_DOCN/sst.day.mean.2019.nc. All other files for each of the failed tests is B4B:Hera RTs were re-run at 86415ba with identical results.
Tests effected by changes in this PR:
Libraries
Code Managers Log
Testing Log: