Python 3 bugfix in ccpp-framework, ESMF 8.1.0bs27, cleanup rt_utils.sh, fix RRTMGP regression tests#201
Conversation
…eyenne.gnu; skip-ci
…ling ccpp_prebuild.py in CMakeLists.txt; skip-ci
…nd testing; skip-ci
…n tests/rt.conf and tests/rt_gnu.conf
|
Note: temporarily added |
| Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) | ||
|
|
||
|
|
||
| Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? |
There was a problem hiding this comment.
Utests can be run on Hera, Orion, Dell with Intel compilers (I had some trouble with ecFlow on Cray)
There was a problem hiding this comment.
Should I add this information to the PR template?
There was a problem hiding this comment.
Since regression tests are supported on all platforms (tier 1, 2, etc.), maybe it would be helpful to add that utests are only supported on tier 1 (Cray will have to come later)? e.g. unit tests (utests on tier 1 platform)
|
@MinsukJi-NOAA thanks for the docker/ci updates, the automated tests all passed |
…tests/fv3_conf/compile_slurm.IN_jet
|
@junwang-noaa @DusanJovic-NOAA this PR is ready from my side. Waiting for CI tests to complete. |
…) (ufs-community#211) * updated CMakeLists.txt * Changes for JEDI linking/control * Update .gitmodules and submodule pointer for ccpp-physics for code review and testing * Revert change to .gitmodules and update submodule pointer for ccpp-physics Co-authored-by: Mark Potts <Mark.Potts@noaa.gov>
Description
This PR:
ccpp_prebuild.pyfromCMakeLists.txttests/rt_utils.shtests/rt.confandtests/rt_gnu.confThe update from ESMF 8.1.0bs21 to ESMF 8.1.0bs27 (unexpectedly) changes the results of the regression tests. No changes in the actual results, but in the metadata of the
phyf*.{nc,nemsio}anddynf*.{nc,nemsio}files:timevariable (counting hourse since forecast initialization) sometimes - but not always, seems to depend on the regridding option - changes fromdoubletofloatTesting
compile_cmake.shis used; however, when usingrt.sh, there is a problem with line 215 inFV3/ccpp/physics/CMakeLists.txt; investigation ongoing, will be fixed in a forthcoming commitSTILL TODO/CONFIRM
tests/rt_utils.sh)Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs