update to latest WW3#199
Merged
junwang-noaa merged 9 commits intoSep 17, 2020
Merged
Conversation
Collaborator
Author
|
NEMS and stochastic_physics were update to their latest develop/master branches as well. New baselines were created on hera, orion and wcoss which included the new WW3_input_data. Answers changed for WW3 tests, but other tests had the same answers as previous baseline. hera (intel), Orion, WCOSS dell_p3 & cray regression tests have now all passed and logs have been pushed. This PR is ready for review. @junwang-noaa @DusanJovic-NOAA @DomHeinzeller |
climbfuji
requested review from
DusanJovic-NOAA,
climbfuji and
junwang-noaa
climbfuji
approved these changes
Sep 17, 2020
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Straightforward, looks good to me.
junwang-noaa
approved these changes
Sep 17, 2020
Collaborator
junwang-noaa
left a comment
junwang-noaa
left a comment
There was a problem hiding this comment.
Great! Now all the subcomponents in ufs-weather are the same as those in s2s.
DusanJovic-NOAA
approved these changes
Sep 17, 2020
pjpegion
added a commit
to NOAA-PSL/ufs-weather-model.p7b
that referenced
this pull request
Jul 20, 2021
…nity#199) This bug fix allows the random patterns in the stochastic physics persist the for a period of time (defined as SKEBINT,SPPTINT, etc.) before calculating new patterns. The fix is to move the allocation of the saved variables into the init section of stochastic_physics_wrapper, and remove the deallocates in the run section.
pjpegion
added a commit
to NOAA-PSL/ufs-weather-model.p7b
that referenced
this pull request
Jul 20, 2021
…erturbations (ufs-community#239) * Update .gitmodules and submodule pointers for ccpp-framework and ccpp-physics for gsl/develop branch * RUC ice for gsl/develop (replaces ufs-community#54 and ufs-community#56) (ufs-community#60) Implementation of RUC LSM ice model in CCPP * Fix bug in gfsphysics/GFS_layer/GFS_typedefs.F90 from merge * Remove lsm_ruc_sfc_sice from suite FV3_GSD_v0_unified_ugwp_suite and update submodule pointer for ccpp-physics * Remove sfc_sice from ccpp/suites/suite_FV3_GSD_v0_unified_ugwp_suite.xml * Update gsl/develop from develop 2020/12/08 (ufs-community#61) * Fix for updating stochastic physics on separate time-step. (ufs-community#199) This bug fix allows the random patterns in the stochastic physics persist the for a period of time (defined as SKEBINT,SPPTINT, etc.) before calculating new patterns. The fix is to move the allocation of the saved variables into the init section of stochastic_physics_wrapper, and remove the deallocates in the run section. * Bug fixes in (1) running with frac_grid=T and GFDL MP and (2) restarting with frac_grid=T (ufs-community#204) * -- Pointing to Moorthi's modifications in ccpp/physics, which fixed the crash when running GFDL MP with frac_grid=T; -- Not setting fice to zero in order to leave lake ice untouched; -- Restart in the coupled model with the default physics is reproducible, if bad water temperature is only filtered at initial time; Co-authored-with: Shrinivas Moorthi <shrinivas.moorthi@noaa.gov> Co-authored-with: Denise Worthen <Denise.Worthen@noaa.gov> * Revert change to .gitmodules and update submodule pointer for ccpp-physics * Update submodule pointer for ccpp-physics - MYNN surface layer updates and bugfixes (ufs-community#63) * Land stochastic perturbations (wrapper PR for ufs-community#65) (ufs-community#68) * Move initialization of stochastic physics after the physics initialization in CCPP. * Add albedo variables to land perturbations with lndp_type=2 option. Change to accommodate soil perturbations with RUC LSM. * Max/min soil moisture variables are introduced via GFS_Control_type variables instead of through the use of namelist_soilveg*. This is a more flexible way for different LSMs. * Added pores and resid variables for max/min soil moisture to GFS_typedefs.f90. * Remove tracer_sanitizer from all suites and from CCPP prebuild config * Add namelist option to apply land surface perturbations at every time step, clean up stochastic_physics/stochastic_physics_wrapper.F90 * Stochastic land perturbations: add roughness length over land to the perturbed variables (ufs-community#70) * Added roughness length over land to the perturbed variables. * Bugfix in gfsphysics/GFS_layer/GFS_typedefs.F90: remove Diag%cldcov, in particular the reset call because the variable is not allocated * Update .gitmodules and submodule pointer for GFDL_atmos_cubed_sphere for code review and testing * Revert change to .gitmodules for ccpp-physics, update submodule pointer for ccpp-physics * Revert change to .gitmodules and update submodule pointer for GFDL_atmos_cubed_sphere Co-authored-by: DomHeinzeller <58610420+DomHeinzeller@users.noreply.github.com> Co-authored-by: Phil Pegion <38869668+pjpegion@users.noreply.github.com> Co-authored-by: shansun6 <48043606+shansun6@users.noreply.github.com> Co-authored-by: tanyasmirnova <tanya.smirnova@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the WW3 submodule pointer to point to the top of the WW3 develop branch. A PR is also submitted to ufs-s2s-model and after both go through, WW3 will use the same commit hash in both s2s and weather.
There will need to be a new baseline to update the input for WW3. This folder has been unified with what is used in ufs-s2s-model and can be seen at /FV3-MOM6-CICE5/develop-202000903/WW3_input_data.
Testing
New baselines for the tests involving waves and updates for wave input will need to be made on all machines. Currently have checked compile on orion and wave tests. Baselines need to be created and then tested on all platforms.