Updates to C3 and SAS convection schemes#1965
Closed
lisa-bengtsson wants to merge 11 commits into
Closed
Conversation
Contributor
Author
|
All RT's pass on Hera: |
36 tasks
Collaborator
|
Incomplete is just waiting on PR review in FV3atm |
Contributor
Author
|
@BrianCurtis-NOAA @SamuelTrahanNOAA my understanding is that we will close this PR and the corresponding FV3 PR as it's been merged with Sam's PR on the global nest. Sam can you confirm that I can close these? |
Collaborator
|
OK that's fine. If you add |
FernandoAndrade-NOAA
pushed a commit
that referenced
this pull request
Nov 15, 2023
* update FD and nems.configure * add new suite_FV3_global_nest_v1 to FV3 * new tests for global_nest_v1 suite * update tests to match new gwd scheme * Namelist changes from Mike Toy & adapt to changes from develop in FV3 * Merge FV3 NOAA-EMC/ufsatm#715 from @lisa-bengtsson * remove unused tests/rap_clm_lake * Update bl_date.conf * note that gnv1_nested might work on s4 * Update cpld_control_p8 remove hera_gnu wall clock stipulation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Author Checklist:
Description
*Brings out tuning parameters from the progsigma_calc.F90, which are used in the saSAS and C3 shallow and deep cumulus convection schemes.
*Adds a limiter on area fraction to not exceed 0.95 after final tuning
*Updates the regression test namelist used for gfsv17 (HR3) tests, to include extracted parameters in the namelist.
For RRFSv1 ensemble members using saSAS convection, workflow updates are needed.
Some justification for the PR can be found here: https://docs.google.com/presentation/d/11WVCFAb-JM628N2RyAWLqjxxrSovKU8AB72xBZJ1FfI/edit#slide=id.p
Linked Issues and Pull Requests
Associated UFSWM Issue to close
Closes #1964
Subcomponent Pull Requests
ufs-community/ccpp-physics#122
NOAA-EMC/ufsatm#715
Blocking Dependencies
None
Subcomponents involved:
Anticipated Changes
Input data
Regression Tests:
Tests effected by changes in this PR:
Libraries
Code Managers Log
Testing Log: