Update Hera and Orion modulefiles to use hpc-stack libs#193
Conversation
|
When will we have the hpc-stack on wcoss too? Or we just keep the current module files on wcoss? |
|
Can we combine this PR with my PR #191? Seems to make sense to me. |
|
I don't know. We should ask NCEPLIBS group. As you can see in one of my commits in this PR (1ab5914) I actually tested it on WCOSS Dell using my hpc-stack build. But that's not 'official' build. |
Sure. |
Great. Then I suggest that I pull in your PR and that we try to make this change today after Clara's code is merged. I can then update the CCPP tendencies PR over the weekend (should be little work) so that we will be ready to roll on Monday. |
junwang-noaa
left a comment
junwang-noaa
left a comment
There was a problem hiding this comment.
The code changes look good to me, but I'd hope we test the same module file in s2s and confirm the same module files work for both before we do the commit
|
Ok, then in this case let's not merge it with my PR and do it after the CCPP tendencies. Glad I didn't pull it in yet.
… On Aug 28, 2020, at 7:58 AM, Jun Wang ***@***.***> wrote:
@junwang-noaa approved this pull request.
The code changes look good to me, but I'd hope we test the same module file in s2s and confirm the same module files work for both before we do the commit
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#193 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RMJDZ5LNHEGUFAEIH3SC6ZYVANCNFSM4QODIOFQ>.
|
|
Difference (24h lowest layer temperature) between this commit and the previous one are on the order of magnitude as the difference between the butterfly test run and the control run of the previous commit:
|
|
Using hpc-stack library, following RT tests show differences while others are not: fv3_cpt_ccpp Taking fv3_csawmg_ccpp test as an example, butterfly test was conducted, the results are at Looking at the tmpsfc field in the phyf025.nemsio files in the above three directory: From grads, the max/min difference of (tmpsfc-tmpsfc.2) is 8 and -8, the average of (tmpsfc-tmpsfc.2) is 0.00210166, the std is 0.27809. From the results the change from hpc-stack is comparable to that from butterfly test. While Dom is debugging the code that causes the difference, if he finds anything that needs to be fixes, he will submit a separate PR. With the results, we will commit the code. |
* New metadata for GP scheme. * Removed redundant importing of kind_phys * add units to index_for_diagnostic_printout metadata * Bugfix in GP sampling routines.
…tic (#193) * Update hash of ufs weather model * Update hash of regional workflow
4 participants
Description
Update Hera(Intel), Orion and WCOSS Dell modulefiles to use hpc-stack libs
New baselines required on Hera (Intel), Orion and WCOSS Dell.
Testing
Regression tests performed on Hera, Orion and WCOSS Dell against new baselines. Hera (GNU) and WCOSS Cray baselines are identical with the previous commits.
Dependencies
N/A