Skip to content

Fix the broken error detection in GFS_phys_time_vary.fv3.F90 and pointer issues in c3 scheme#1917

Closed
SamuelTrahanNOAA wants to merge 12 commits into
ufs-community:developfrom
SamuelTrahanNOAA:bugfix/errmsgflg-race-condition
Closed

Fix the broken error detection in GFS_phys_time_vary.fv3.F90 and pointer issues in c3 scheme#1917
SamuelTrahanNOAA wants to merge 12 commits into
ufs-community:developfrom
SamuelTrahanNOAA:bugfix/errmsgflg-race-condition

Conversation

@SamuelTrahanNOAA
Copy link
Copy Markdown
Collaborator

@SamuelTrahanNOAA SamuelTrahanNOAA commented Sep 22, 2023 •
edited
Loading

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
    • LOG: committed to repository
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

Inside CCPP, there were several bugs in the error detection in GFS_phys_time_vary.fv3.F90. Errors might go undetected, or may be reported incorrectly. This was uncovered by @hu5970's RRFS runs.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

All issues are in the ccpp-physics repository within the FV3 subcomponent.

Subcomponent Pull Requests

Blocking Dependencies

None

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.

Regression Tests:

  • Changes are expected to the following tests:
    • Remove hrrr_gf and hrrr_c3
    • Add hrrr_gf_debug and hrrr_c3_debug (run for both compilers)
Expand for full list in conf format 
COMPILE | atm_debug_dyn32 | intel | -DAPP=ATM -DDEBUG=ON -D32BIT=ON -DCCPP_SUITES=FV3_HRRR,FV3_GFS_v16,FV3_GFS_v16_csawmg,FV3_GFS_v16_ras,FV3_GFS_v17_p8,FV3_GFS_v15_thompson_mynn_lam3km,FV3_RAP,FV3_RAP_unified_ugwp,FV3_RAP_cires_ugwp,FV3_RAP_flake,FV3_RAP_clm_lake,FV3_RAP_noah,FV3_RAP_sfcdiff,FV3_RAP_noah_sfcdiff_cires_ugwp,FV3_RRFS_v1beta,FV3_HRRR_c3,FV3_HRRR_gf | - noaacloud  | fv3 |
RUN | hrrr_gf_debug                                     | - noaacloud                  | baseline |
RUN | hrrr_c3_debug                                     | - noaacloud                  | baseline |

COMPILE | atm_dyn32_debug | gnu | -DAPP=ATM -D32BIT=ON -DDEBUG=ON | + hera cheyenne hercules | fv3 |
RUN | hrrr_gf_debug                                     | + hera cheyenne hercules            | baseline |
RUN | hrrr_c3_debug                                     | + hera cheyenne hercules            | baseline |

Libraries

  • Not Needed
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@SamuelTrahanNOAA SamuelTrahanNOAA mentioned this pull request Sep 22, 2023
Merged
34 tasks
@SamuelTrahanNOAA
Copy link
Copy Markdown
Collaborator Author

SamuelTrahanNOAA commented Sep 25, 2023

This PR's branch has been merged into #1903

@SamuelTrahanNOAA SamuelTrahanNOAA mentioned this pull request Sep 25, 2023
Closed
@SamuelTrahanNOAA SamuelTrahanNOAA changed the title Fix the broken error detection in CCPP's GFS_phys_time_vary.fv3.F90 Fix the broken error detection in GFS_phys_time_vary.fv3.F90 and pointer issues in c3 scheme Sep 28, 2023
jkbk2004 pushed a commit that referenced this pull request Oct 3, 2023
@SamuelTrahanNOAA @haiqinli
Quartet of bug fixes for: c3 scheme, quilting restart with 32-bit phy…
41811b8 
…sics, and string length mismatch in dycore (plus PR #1913, #1917, and #1926) (#1893)

* GFDL_atmos_cubed_sphere: consistent string lengths in array

* stop FV3_HRRR_c3 from crashing with gnu debug

* 1hr forecast limit for conus13km_debug_qr

* fv3atm: bug fix from Dusan to recover_fields crash

* disable conus13km_debug_qr_gnu due to 25% failure rate on Hera

* FV3 dycore: initialize srf_wnd_var2 and tracers_var3 arrays

* enable conus13km_debug_qr_gnu

* Fix race condition in GFS_phys_time_vary.fv3.F90 error detection

* More bug fixes to GFS_phys_time_vary.fv3.F90:
1. detect empty errmsg from subroutines
2. Initialize err variables in set_soilveg.f, which is called from GFS_phys_time_vary.fv3.F90

* ccpp-physics: initialize errmsg & errflg in noahmp_tables.f90

* ccpp-physics: only read h2odata, ozdata and noahmp table when they are needed

* "point to the dimension fix of smc for dust emission"

* FV3: more dycore bug fixes from GFDL_atmos_cubed_sphere PR 285

* merge #1926

* merge GFDL_atmos_cubed_sphere #276

* bugfix: 12hr hrrr tests

* add GAEA rocoto support

* fv3: merge GF radar fixes

* check that baseline directory exists and is non-empty

---------

Co-authored-by: Haiqin.Li <Haiqin.Li@noaa.gov>
@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Oct 3, 2023

Merged with #1893

@jkbk2004 jkbk2004 closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment