Skip to content

Update CICE#1842

Merged
FernandoAndrade-NOAA merged 49 commits into
ufs-community:developfrom
DeniseWorthen:feature/updcice
Aug 2, 2023
Merged

Update CICE#1842
FernandoAndrade-NOAA merged 49 commits into
ufs-community:developfrom
DeniseWorthen:feature/updcice

Conversation

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@DeniseWorthen DeniseWorthen commented Jul 25, 2023 •
edited
Loading

Description

Update CICE to latest Consortium/main

Input data additions/changes

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

RegressionTests_hera.log

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Library Updates/Changes

  • Not Needed
  • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
  • Add issue link from JCSDA/spack-stack following this item

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved in section below
  • Confirm reviews completed in ALL sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne AND attach log to a PR comment.
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne N/A (offline)
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

DeniseWorthen and others added 30 commits January 7, 2023 00:12
@DeniseWorthen
hera.intel testing shows
8c0b608 
* reverting the bug fix for ktherm=2 allows all cpld tests to pass
and the single datm test using ktherm=2 (datm_cdeps_gfs) to also pass
all other datm tests which use ktherm=1 fail
@DeniseWorthen
confirm cice testb16d7fd is b4b for all datm/cpld tests
3619de3
@DeniseWorthen
Merge branch 'ufs-community:develop' into feature/updcice
11016e4
@DeniseWorthen
update CICE
a8cacb3
@DeniseWorthen
fix alignments in rt.conf, rt_gnu.conf
4eaf074
@DeniseWorthen
Merge branch 'ufs-community:develop' into feature/updcice
32d5ff2
@DeniseWorthen
update CICE (no code changes)
adc486b
@DeniseWorthen
Merge branch 'ufs-community:develop' into feature/updcice
d3b2469
@DeniseWorthen
Merge branch 'ufs-community:develop' into feature/updcice
45c851b
@jkbk2004
add new BL_DATE
742f77c
@BrianCurtis-NOAA
[AutoRT] hera.gnu Job Completed.
c867e50 
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@BrianCurtis-NOAA
[AutoRT] hera.intel Job Completed.
45130a8 
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@BrianCurtis-NOAA
[AutoRT] orion.intel Job Completed.
0e5d6a0 
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@BrianCurtis-NOAA
[AutoRT] jet.intel Job Completed.
5e3fefb 
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@BrianCurtis-NOAA
Acorn Intel RT Log
9fbf65a
@jkbk2004
add cheyenne intel.gnu RT logs: passed
eba063d
@jkbk2004
add gaea.intel RT log: passed
e8227ed
@DeniseWorthen
update CICE and revert gitmodules
e5c62f7
@DeniseWorthen
Merge branch 'develop' into feature/updcice
d850095
@DeniseWorthen
update CICE gitmodule
c0a04c4
@DeniseWorthen
Merge branch 'ufs-community:develop' into feature/updcice
4dd3f5c
@DeniseWorthen
Merge branch 'ufs-community:develop' into feature/updcice
fa7f4f9
@epic-cicd-jenkins
[AutoRT] cheyenne.gnu Job Completed.
ae96b23 
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@jkbk2004
[AutoRT] hera.intel Job Completed.
b2907f0 
on-behalf-of @ufs-community <jong.kim@noaa.gov>
@epic-cicd-jenkins
[AutoRT] cheyenne.intel Job Completed.
6e55f74 
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@jkbk2004
[AutoRT] hera.gnu Job Completed.
dd343b7 
on-behalf-of @ufs-community <jong.kim@noaa.gov>
@zach1221
add orion.intel RT logs: passed
74b1688
@zach1221
add jet.intel RT logs: passed
23d0923
@jkbk2004
[AutoRT] gaea.intel Job Completed.
44cc9da 
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@BrianCurtis-NOAA
Acorn Intel RT Log
e77011e
@epic-cicd-jenkins epic-cicd-jenkins removed the jet-RT Run AutoRT Jet regression testing label Aug 1, 2023
@FernandoAndrade-NOAA FernandoAndrade-NOAA removed the hera-RT Run Hera regression testing label Aug 1, 2023
@epic-cicd-jenkins
[AutoRT] hera Job Completed.
0c40396 
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
junwang-noaa
junwang-noaa reviewed Aug 2, 2023
View reviewed changes
Comment thread tests/parm/nems.configure.atmw.IN
junwang-noaa
junwang-noaa previously approved these changes Aug 2, 2023
View reviewed changes
sadeghitabas
sadeghitabas previously approved these changes Aug 2, 2023
View reviewed changes
@DeniseWorthen
Copy link
Copy Markdown
Collaborator Author

DeniseWorthen commented Aug 2, 2023

@BrianCurtis-NOAA Any hope of getting an Acorn log or is it flakey today?

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

BrianCurtis-NOAA commented Aug 2, 2023

@FernandoAndrade-NOAA @DeniseWorthen The full disk earlier seemed to mess with my baselines from the previous PR, so i'll re-do them tonight to confirm, with no baseline change, shouldn't be a problem to skip to merge now.

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

FernandoAndrade-NOAA commented Aug 2, 2023

@FernandoAndrade-NOAA @DeniseWorthen The full disk earlier seemed to mess with my baselines from the previous PR, so i'll re-do them tonight to confirm, with no baseline change, shouldn't be a problem to skip to merge now.

Understood, in that case this PR should be ready to begin the merge process.

@FernandoAndrade-NOAA FernandoAndrade-NOAA mentioned this pull request Aug 2, 2023
Merged
@DeniseWorthen DeniseWorthen dismissed stale reviews from sadeghitabas and junwang-noaa via 8cf2233 August 2, 2023 21:11
@FernandoAndrade-NOAA FernandoAndrade-NOAA merged commit 641887b into ufs-community:develop Aug 2, 2023
@FernandoAndrade-NOAA FernandoAndrade-NOAA mentioned this pull request Aug 3, 2023
Merged
37 tasks
@DeniseWorthen DeniseWorthen mentioned this pull request Aug 21, 2023
Closed
@grantfirl grantfirl mentioned this pull request Nov 2, 2023
Merged
@DeniseWorthen DeniseWorthen self-assigned this Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FernandoAndrade-NOAA FernandoAndrade-NOAA FernandoAndrade-NOAA left review comments

@jkbk2004 jkbk2004 jkbk2004 approved these changes

@BrianCurtis-NOAA BrianCurtis-NOAA Awaiting requested review from BrianCurtis-NOAA

@junwang-noaa junwang-noaa Awaiting requested review from junwang-noaa

+1 more reviewer

@sadeghitabas sadeghitabas sadeghitabas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DeniseWorthen DeniseWorthen

Labels

jenkins-ci Jenkins CI: ORT build/test on docker container No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.

Projects

None yet

Milestone

No milestone

8 participants

@DeniseWorthen @sadeghitabas @FernandoAndrade-NOAA @BrianCurtis-NOAA @junwang-noaa @jkbk2004 @epic-cicd-jenkins @zach1221