Downgrade FMS to 2019.01.03#179
Merged
Merged
Conversation
DusanJovic-NOAA
requested review from
MinsukJi-NOAA,
climbfuji and
junwang-noaa
junwang-noaa
approved these changes
Aug 4, 2020
Collaborator
junwang-noaa
left a comment
junwang-noaa
left a comment
There was a problem hiding this comment.
The code changes look good to me. I noticed that the atmos_4xdaily files are still there, so I assume we will have another commit to clean up that.
climbfuji
reviewed
Aug 4, 2020
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Looks good to me - I'll try this code on cheyenne while we are waiting for hera to come back.
climbfuji
approved these changes
Aug 5, 2020
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
I tested killing jobs on Cheyenne and it seems to work:
kill -15on the rt.sh job kills all jobs in the queue- hitting
Ctrl + Cfrom the rt.sh job itself doesn't kill the queued jobs (is this intended?)
Collaborator
|
To complete the testing, I ran the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Downgrade FMS to 2019.01.03.
Small changes in cmake build system due to FMS version change.
Improve error handling in rt.sh when ecflow is used. Scripts cleanup and refactoring.
Issue(s) addressed
In order to merge (unify) ufs-weather-model and ufs-s2s-model changing the FMS to the exact version used by s2s is required.
Testing
Regression test will be performed on all Tier-1 platforms.
New baseline (develop-20200805) has been created, because of file format change in FMS (CDF2 to HDF5). All restart files and all history files (created using write component) are bit-identical.
Dependencies
N/A