Skip to content

Updates for the Community Convective Cloud (C3) scheme#1766

Closed
haiqinli wants to merge 2 commits into
ufs-community:developfrom
haiqinli:develop-c3
Closed

Updates for the Community Convective Cloud (C3) scheme#1766
haiqinli wants to merge 2 commits into
ufs-community:developfrom
haiqinli:develop-c3

Conversation

@haiqinli
Copy link
Copy Markdown
Contributor

@haiqinli haiqinli commented May 23, 2023

Description

  1. Name the new unified convective parameterization as "Community Convective Cloud (c3) parameterization";
  2. Update the aerosol-aware for GF;
  3. Merge the aerosol-aware and RRFS configuration from GF into C3;
  4. Make the closures as input namelist options for C3 and GF.

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

The following RT's are failed as expected because of the GF updates.
rap_2threads_dyn32_phy32 rap_control_dyn32_phy32.err rap_flake_debug rap_sfcdiff_decomp
rap_2threads rap_control_dyn64_phy32_debug rap_lndp_debug rap_sfcdiff
rap_cires_ugwp_debug rap_control_dyn64_phy32 rap_noah_debug rap_unified_drag_suite_debug
rap_clm_lake_debug rap_control rap_noah_sfcdiff_cires_ugwp_debug rap_unified_ugwp_debug
rap_control_debug_dyn32_phy32 rap_decomp rap_progcld_thompson_debug
rap_control_debug rap_diag_debug rap_sfcdiff_debug

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

@DusanJovic-NOAA DusanJovic-NOAA changed the title updates for the Community Convective Cloud (C3) scheme Updates for the Community Convective Cloud (C3) scheme Jun 14, 2023
@jkbk2004
Copy link
Copy Markdown
Collaborator

We are about to merge in #1752. If you are available, we can follow on this pr. Have you tested this pr wither on hera or cheyenne?

@jkbk2004
Copy link
Copy Markdown
Collaborator

Also, can you update the PR description to link in fv3 and ccpp PRs?

@haiqinli
Copy link
Copy Markdown
Contributor Author

@jkbk2004 Yes, I tested it on Hera a few weeks ago. Sure, I will sync the ccpp-physics and also update the link to fv3atm and ufs-weather-model. Thanks.

@jkbk2004
Copy link
Copy Markdown
Collaborator

Sure! go ahead to sync up.

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@jkbk2004 This PR template is not complete. It appears sections were removed.

Copy link
Copy Markdown
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both CDEPS and CMEPS are out of date

@haiqinli haiqinli closed this Jun 14, 2023
@haiqinli haiqinli deleted the develop-c3 branch June 14, 2023 22:11
@haiqinli
Copy link
Copy Markdown
Contributor Author

@DeniseWorthen I reestablished the develop-c3 branch with the latest version ufs-weather-model. But it seems the PR was automatically closed. Thus I reopen this PR. Thanks.

@jkbk2004
Copy link
Copy Markdown
Collaborator

@haiqinli it's still closed. If you need time, we can let #1769 go first.

@haiqinli
Copy link
Copy Markdown
Contributor Author

@jkbk2004 This PR is ready. I tried to reopen this PR, but was not successful. Would you like to reopen this PR? Thanks.

@haiqinli
Copy link
Copy Markdown
Contributor Author

@jkbk2004 @DeniseWorthen Actually the regression test of this PR with Intel compiler on Hera just successfully done at /scratch1/BMC/gsd-fv3-dev/Haiqin.Li/HFIP/Commit/ufs-weather-model/tests/logs/RegressionTests_hera.log. I am starting the GNU/Hera regression test.

@haiqinli
Copy link
Copy Markdown
Contributor Author

@jkbk2004 @DeniseWorthen
I was not able to update CDEPS and CMEPS. Then I reestablished the develop-c3 branch. Unfortunately, the PR was automatically closed, and I could not reopen it.
If both of us could not reopen this PR, I may open a new supplementary PR, which may only take a few minutes.

@jkbk2004
Copy link
Copy Markdown
Collaborator

Looks like branch was deleted after pr was closed. Git is not going to let pr reopen if there is change/commit with pr closed. I agree with opening a new pr. BTW, #1769 is ready. So we can schedule new pr after we merge #1769.

@haiqinli
Copy link
Copy Markdown
Contributor Author

@jkbk2004 I am starting a new PR, and it should be ready in just a new minutes. I don't want my PR to de delayed. Thanks.

@haiqinli
Copy link
Copy Markdown
Contributor Author

@jkbk2004 I created a new PR of #1795, and it has successfully passed the Intel/Hera and GNU/Hera regression test, and it is ready. I hope my PR will be merged as scheduled. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants