update FV3 to better handle data source for regional model LBC processing and combined with #1730 WW3 update#1715
Conversation
Use nccmp to compare netcdf files in regression test on NOAA R&D mach…
|
@Jili-Dong There are two urgent PRs on-going this week: #1720 and another PR physics. We need to re-schedule this PR to next week. |
|
@jkbk2004 could you combine this PR with any of the PR you mentioned as this PR is a quite simple one and won't change any baseline |
|
Since it just needs to point to the cubed sphere branch, the best chance is to combine with next physics PR that we are targeting by Friday. I will keep you posted. |
|
@jkbk2004 sounds good. Thanks |
|
@Jili-Dong can you add PR description section? you can copy in the pr template: https://github.com/ufs-community/ufs-weather-model/blob/develop/.github/pull_request_template.md |
|
@jkbk2004 PR description section added |
|
@Jili-Dong can you combine in @MatthewMasarik-NOAA #1730 ww3 branch? Or I may jump in to see if I can directly update your fork. @MatthewMasarik-NOAA if you are still available, can you create a direct pr to Jili's branch? |
|
@jkbk2004 @MatthewMasarik-NOAA #1730 has been combined with this PR. Please let me know if it looks right. |
|
@Jili-Dong thanks for following up! can you update pr title to reflect #1730 and add a line to the linked PR section in the description? I will let the tests run over weekend. @BrianCurtis-NOAA I am running on this PR. |
|
@jkbk2004 updated as requested |
|
@BrianCurtis-NOAA note that rrfs_conus13km_hrrr_warm_restart_mismatch changes as well. |
|
Jenkins-ci logs attached. ORTs passed Ok. @jkbk2004 I can inquire about nccmp with Cheyenne system admin, no problem. |
|
@BrianCurtis-NOAA skip the test on acorn? |
|
No, looks to be almost done. |
|
All tests are done. we can start merging process. |
|
@Jili-Dong fv3 pr and ww3 pr were merged. Can you update hases and revert change in gitmodules? fv3 hash: NOAA-EMC/ufsatm@832803b ww3 hash: NOAA-EMC/WW3@7c93224 |
@jkbk2004 gitmodules and hashes updated |
Description
Top of commit queue on: TBD
Input data additions/changes
Anticipated changes to regression tests:
rrfs_smoke_conus13km_hrrr_warm
rrfs_smoke_conus13km_hrrr_warm_2threads
rrfs_conus13km_hrrr_warm
rrfs_smoke_conus13km_radar_tten_warm
rrfs_smoke_conus13km_hrrr_warm_debug
rrfs_smoke_conus13km_hrrr_warm_debug_2threads
rrfs_conus13km_hrrr_warm_debug
rrfs_conus13km_hrrr_warm_restart_mismatch
The above tests have incorrect processing of LBC which has been corrected by this PR. A slide has been attached in discussions to explain the difference.
Subcomponents involved:
Combined with PR's (If Applicable):
#1730
Commit Queue Checklist:
Linked PR's and Issues:
combined with #1730
Depends on fv3atm#646
Testing Day Checklist:
Testing Log (for CM's):
Related to submodule FV3:
NOAA-EMC/ufsatm#646
It is not expected to change any RT results.
Related to issue:
#1716