Enable usage of shared pio#1640
Closed
ulmononian wants to merge 2 commits into
Closed
Conversation
Collaborator
Author
climbfuji
approved these changes
Mar 3, 2023
Collaborator
climbfuji
left a comment
There was a problem hiding this comment.
Thanks for doing this!
Collaborator
|
@ulmononian we are considering to combine in #1617. I will keep you posted to finalize the review process of this pr. |
This was referenced Mar 7, 2023
Merged
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently,
CMakeLists.txtrequires static builds ofparallelio(see these lines). A relaxation of this requirement (i.e.: to allow shared or static versions ofparallelio) could be facilitated by updatingCMakeModulesto its develop branch, whereFindPIO.cmakecan automatically accommodate both static or shared builds.Apart from updating
CMakeModulesto develop, theSTATICrequirement would need to be removed fromCMakeLists.txt.This change is in anticipation of transition from hpc-stack to spack-stack, where
paralleliois currently being built as a shared library (see NOAA-EMC/spack-stack PR #454, issue #478).RT
cpld_contrl_p8passed on Orion (Intel) and Hera (Intel & GNU) (logs in comments). I will report further RT results as they complete.Anticipated changes to regression tests:
Subcomponents involved:
Commit Queue Checklist:
Linked PR's and Issues:
Addresses #1512
Testing Day Checklist:
Testing Log (for CM's):