This is EMC flake model#164
Conversation
| @@ -0,0 +1,338 @@ | |||
| &amip_interp_nml | |||
There was a problem hiding this comment.
Could this parm file be joined with the existing GFS v16 beta parm file, using variable substitutions?
|
|
||
| cp ${PATHRT}/../FV3/ccpp/suites/suite_${CCPP_SUITE}.xml suite_${CCPP_SUITE}.xml | ||
|
|
||
| # Add path to libccpp.so and libccpphys.so to LD_LIBRARY_PATH, append to module-setup.sh |
There was a problem hiding this comment.
This block (lines 24-28) is no longer needed, please remove.
| @@ -0,0 +1,28 @@ | |||
| rm -fr INPUT RESTART | |||
There was a problem hiding this comment.
Could this regression test setup-run-dir script be joined with an existing script, using variables to control copying the ORO_FLAKE data?
There was a problem hiding this comment.
I'd prefer to have this new feature separate from gfs_v16 as the feature does not belong to gfs_v16, but based on gfs_v16. In the future it can be one of candidate to be included in next production branch, srw, RRFS, or gfsv17.
| COMPILE | CCPP=Y SUITES=FV3_GFS_2017_gfdlmp,FV3_GFS_2017_gfdlmp_noahmp | standard | jet.intel | fv3 | | ||
|
|
||
| RUN | fv3_ccpp_gocart_clm | standard | | fv3 | | ||
| ###################################################################################################################################################################################### |
There was a problem hiding this comment.
Is it possible to combine this COMPILE line with a previous one (for example where the original GFSv16beta suite is compiled) to avoid an extra compile step?
There was a problem hiding this comment.
Also, please add this regression test to rt_gnu.conf as well. @junwang-noaa @DusanJovic-NOAA
|
Hi, Dom,
In parm/ccpp_v16beta_flake_c96.nml.IN
<#164 (comment)>
:
@@ -0,0 +1,338 @@
+&amip_interp_nml
Could this parm file be joined with the existing GFS v16 beta parm
file, using variable substitutions?
Yes. Could you show me How can I do it. I am familiar with the
setup of these files.
Thanks! Regards
*Yihua----------------------------------------------------Yihua Wu, Ph D*I.M.
Systems Group
NOAA/NWS/NCEP/EMC
5830 University Research Court, Room: 2031
College Park, Maryland 20740, USA
Phone: (301)-683-3691
Fax: (301)-683-3703
…On Thu, Jul 16, 2020 at 9:14 AM Dom Heinzeller ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In parm/ccpp_v16beta_flake_c96.nml.IN
<#164 (comment)>
:
> @@ -0,0 +1,338 @@
+&amip_interp_nml
Could this parm file be joined with the existing GFS v16 beta parm file,
using variable substitutions?
------------------------------
In tests/fv3_conf/ccpp_gfs_v16_flake_run.IN
<#164 (comment)>
:
> +fi
+cp @[RTPWD]/FV3_input_data/INPUT/aerosol.dat .
+cp @[RTPWD]/FV3_input_data/INPUT/co2historicaldata_201*.txt .
+cp @[RTPWD]/FV3_input_data/INPUT/sfc_emissivity_idx.txt .
+cp @[RTPWD]/FV3_input_data/INPUT/solarconstant_noaa_an.txt .
+cp @[RTPWD]/FV3_input_data/ozprdlos_2015_new_sbuvO3_tclm15_nuchem.f77 ./global_o3prdlos.f77
+cp @[RTPWD]/FV3_input_data/global_h2o_pltc.f77 ./global_h2oprdlos.f77
+cp @[RTPWD]/FV3_input_data/*grb .
+cp @[RTPWD]/FV3_input_data/*_table .
+cp @[RTPWD]/FV3_input_data/diag_table_gfdlmp diag_table
+cp @[RTPWD]/FV3_input_data_gsd/field_table_suite2 field_table
+cp @[RTPWD]/FV3_input_data/*configure .
+
+cp ${PATHRT}/../FV3/ccpp/suites/suite_${CCPP_SUITE}.xml suite_${CCPP_SUITE}.xml
+
+# Add path to libccpp.so and libccpphys.so to LD_LIBRARY_PATH, append to module-setup.sh
This block (lines 24-28) is no longer needed, please remove.
------------------------------
In tests/fv3_conf/ccpp_gfs_v16_flake_run.IN
<#164 (comment)>
:
> @@ -0,0 +1,28 @@
+rm -fr INPUT RESTART
Could this regression test setup-run-dir script be joined with an existing
script, using variables to control copying the ORO_FLAKE data?
------------------------------
In tests/rt.conf
<#164 (comment)>
:
> @@ -166,3 +166,7 @@ COMPILE | CCPP=Y SUITES=FV3_GFS_2017_gfdlmp,FV3_GFS_2017_gfdlmp_noahmp
COMPILE | CCPP=Y SUITES=FV3_GFS_2017_gfdlmp,FV3_GFS_2017_gfdlmp_noahmp | standard | jet.intel | fv3 |
RUN | fv3_ccpp_gocart_clm | standard | | fv3 |
+######################################################################################################################################################################################
Is it possible to combine this COMPILE line with a previous one (for
example where the original GFSv16beta suite is compiled) to avoid an extra
compile step?
------------------------------
In tests/rt.conf
<#164 (comment)>
:
> @@ -166,3 +166,7 @@ COMPILE | CCPP=Y SUITES=FV3_GFS_2017_gfdlmp,FV3_GFS_2017_gfdlmp_noahmp
COMPILE | CCPP=Y SUITES=FV3_GFS_2017_gfdlmp,FV3_GFS_2017_gfdlmp_noahmp | standard | jet.intel | fv3 |
RUN | fv3_ccpp_gocart_clm | standard | | fv3 |
+######################################################################################################################################################################################
Also, please add this regression test to rt_gnu.conf as well.
@junwang-noaa <https://github.com/junwang-noaa> @DusanJovic-NOAA
<https://github.com/DusanJovic-NOAA>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#164 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANJBYQHL2EJ7N4OGDBNVYE3R334MTANCNFSM4OW5GIQA>
.
|
|
Look at parm/ccpp_gsd.nml.IN for example. You see many examples of variables like @[LHEATSTRG] that get substituted with actual values.
The default values are set in tests/default_vars.sh - regression tests that need to change some of these values do so in their tests/tests/REGTESTNAME script.
You can diff the basic GFSv16beta parm file with yours to see what needs to be added/changed. Then add those as variables to the default GFSv16 parm file, make sure there are default values defined in tests/default_vars.sh and that the default values are correct, then overwrite them in tests/tests/YOURFLAKEREGTESTNAME.
Does this make sense?
Dom
… On Jul 16, 2020, at 8:39 AM, YihuaWu-NOAA ***@***.***> wrote:
Hi, Dom,
In parm/ccpp_v16beta_flake_c96.nml.IN
<#164 (comment)>
:
> @@ -0,0 +1,338 @@
+&amip_interp_nml
Could this parm file be joined with the existing GFS v16 beta parm
file, using variable substitutions?
Yes. Could you show me How can I do it. I am familiar with the
setup of these files.
Thanks! Regards
*Yihua----------------------------------------------------Yihua Wu, Ph D*I.M.
Systems Group
NOAA/NWS/NCEP/EMC
5830 University Research Court, Room: 2031
College Park, Maryland 20740, USA
Phone: (301)-683-3691
Fax: (301)-683-3703
On Thu, Jul 16, 2020 at 9:14 AM Dom Heinzeller ***@***.***>
wrote:
> ***@***.**** requested changes on this pull request.
> ------------------------------
>
> In parm/ccpp_v16beta_flake_c96.nml.IN
> <#164 (comment)>
> :
>
> > @@ -0,0 +1,338 @@
>
> +&amip_interp_nml
>
>
> Could this parm file be joined with the existing GFS v16 beta parm file,
> using variable substitutions?
> ------------------------------
>
> In tests/fv3_conf/ccpp_gfs_v16_flake_run.IN
> <#164 (comment)>
> :
>
> > +fi
>
> +cp @[RTPWD]/FV3_input_data/INPUT/aerosol.dat .
>
> +cp @[RTPWD]/FV3_input_data/INPUT/co2historicaldata_201*.txt .
>
> +cp @[RTPWD]/FV3_input_data/INPUT/sfc_emissivity_idx.txt .
>
> +cp @[RTPWD]/FV3_input_data/INPUT/solarconstant_noaa_an.txt .
>
> +cp @[RTPWD]/FV3_input_data/ozprdlos_2015_new_sbuvO3_tclm15_nuchem.f77 ./global_o3prdlos.f77
>
> +cp @[RTPWD]/FV3_input_data/global_h2o_pltc.f77 ./global_h2oprdlos.f77
>
> +cp @[RTPWD]/FV3_input_data/*grb .
>
> +cp @[RTPWD]/FV3_input_data/*_table .
>
> +cp @[RTPWD]/FV3_input_data/diag_table_gfdlmp diag_table
>
> +cp @[RTPWD]/FV3_input_data_gsd/field_table_suite2 field_table
>
> +cp @[RTPWD]/FV3_input_data/*configure .
>
> +
>
> +cp ${PATHRT}/../FV3/ccpp/suites/suite_${CCPP_SUITE}.xml suite_${CCPP_SUITE}.xml
>
> +
>
> +# Add path to libccpp.so and libccpphys.so to LD_LIBRARY_PATH, append to module-setup.sh
>
>
> This block (lines 24-28) is no longer needed, please remove.
> ------------------------------
>
> In tests/fv3_conf/ccpp_gfs_v16_flake_run.IN
> <#164 (comment)>
> :
>
> > @@ -0,0 +1,28 @@
>
> +rm -fr INPUT RESTART
>
>
> Could this regression test setup-run-dir script be joined with an existing
> script, using variables to control copying the ORO_FLAKE data?
> ------------------------------
>
> In tests/rt.conf
> <#164 (comment)>
> :
>
> > @@ -166,3 +166,7 @@ COMPILE | CCPP=Y SUITES=FV3_GFS_2017_gfdlmp,FV3_GFS_2017_gfdlmp_noahmp
>
> COMPILE | CCPP=Y SUITES=FV3_GFS_2017_gfdlmp,FV3_GFS_2017_gfdlmp_noahmp | standard | jet.intel | fv3 |
>
>
>
> RUN | fv3_ccpp_gocart_clm | standard | | fv3 |
>
> +######################################################################################################################################################################################
>
>
> Is it possible to combine this COMPILE line with a previous one (for
> example where the original GFSv16beta suite is compiled) to avoid an extra
> compile step?
> ------------------------------
>
> In tests/rt.conf
> <#164 (comment)>
> :
>
> > @@ -166,3 +166,7 @@ COMPILE | CCPP=Y SUITES=FV3_GFS_2017_gfdlmp,FV3_GFS_2017_gfdlmp_noahmp
>
> COMPILE | CCPP=Y SUITES=FV3_GFS_2017_gfdlmp,FV3_GFS_2017_gfdlmp_noahmp | standard | jet.intel | fv3 |
>
>
>
> RUN | fv3_ccpp_gocart_clm | standard | | fv3 |
>
> +######################################################################################################################################################################################
>
>
> Also, please add this regression test to rt_gnu.conf as well.
> @junwang-noaa <https://github.com/junwang-noaa> @DusanJovic-NOAA
> <https://github.com/DusanJovic-NOAA>
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#164 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ANJBYQHL2EJ7N4OGDBNVYE3R334MTANCNFSM4OW5GIQA>
> .
>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#164 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RKHHNFAHT4V4HEWKULR34GLZANCNFSM4OW5GIQA>.
|
|
I removed line 24-28 in tests/fv3_conf/ccpp_gfs_v16_flake_run.IN
<#164 (comment)>
I combined the compiling lines for flake
I added the regression test to rt_gnu.conf .
Thanks!
*Yihua----------------------------------------------------Yihua Wu, Ph D*I.M.
Systems Group
NOAA/NWS/NCEP/EMC
5830 University Research Court, Room: 2031
College Park, Maryland 20740, USA
Phone: (301)-683-3691
Fax: (301)-683-3703
On Thu, Jul 16, 2020 at 10:39 AM Yihua. Wu - NOAA Affiliate <
yihua.wu@noaa.gov> wrote:
… Hi, Dom,
In parm/ccpp_v16beta_flake_c96.nml.IN
<#164 (comment)>
:
> @@ -0,0 +1,338 @@
+&amip_interp_nml
Could this parm file be joined with the existing GFS v16 beta parm file, using variable substitutions?
Yes. Could you show me How can I do it. I am familiar with the setup of these files.
Thanks! Regards
*Yihua----------------------------------------------------Yihua Wu, Ph D*I.M.
Systems Group
NOAA/NWS/NCEP/EMC
5830 University Research Court, Room: 2031
College Park, Maryland 20740, USA
Phone: (301)-683-3691
Fax: (301)-683-3703
On Thu, Jul 16, 2020 at 9:14 AM Dom Heinzeller ***@***.***>
wrote:
> ***@***.**** requested changes on this pull request.
> ------------------------------
>
> In parm/ccpp_v16beta_flake_c96.nml.IN
> <#164 (comment)>
> :
>
> > @@ -0,0 +1,338 @@
>
> +&amip_interp_nml
>
>
> Could this parm file be joined with the existing GFS v16 beta parm file,
> using variable substitutions?
> ------------------------------
>
> In tests/fv3_conf/ccpp_gfs_v16_flake_run.IN
> <#164 (comment)>
> :
>
> > +fi
>
> +cp @[RTPWD]/FV3_input_data/INPUT/aerosol.dat .
>
> +cp @[RTPWD]/FV3_input_data/INPUT/co2historicaldata_201*.txt .
>
> +cp @[RTPWD]/FV3_input_data/INPUT/sfc_emissivity_idx.txt .
>
> +cp @[RTPWD]/FV3_input_data/INPUT/solarconstant_noaa_an.txt .
>
> +cp @[RTPWD]/FV3_input_data/ozprdlos_2015_new_sbuvO3_tclm15_nuchem.f77 ./global_o3prdlos.f77
>
> +cp @[RTPWD]/FV3_input_data/global_h2o_pltc.f77 ./global_h2oprdlos.f77
>
> +cp @[RTPWD]/FV3_input_data/*grb .
>
> +cp @[RTPWD]/FV3_input_data/*_table .
>
> +cp @[RTPWD]/FV3_input_data/diag_table_gfdlmp diag_table
>
> +cp @[RTPWD]/FV3_input_data_gsd/field_table_suite2 field_table
>
> +cp @[RTPWD]/FV3_input_data/*configure .
>
> +
>
> +cp ${PATHRT}/../FV3/ccpp/suites/suite_${CCPP_SUITE}.xml suite_${CCPP_SUITE}.xml
>
> +
>
> +# Add path to libccpp.so and libccpphys.so to LD_LIBRARY_PATH, append to module-setup.sh
>
>
> This block (lines 24-28) is no longer needed, please remove.
> ------------------------------
>
> In tests/fv3_conf/ccpp_gfs_v16_flake_run.IN
> <#164 (comment)>
> :
>
> > @@ -0,0 +1,28 @@
>
> +rm -fr INPUT RESTART
>
>
> Could this regression test setup-run-dir script be joined with an
> existing script, using variables to control copying the ORO_FLAKE data?
> ------------------------------
>
> In tests/rt.conf
> <#164 (comment)>
> :
>
> > @@ -166,3 +166,7 @@ COMPILE | CCPP=Y SUITES=FV3_GFS_2017_gfdlmp,FV3_GFS_2017_gfdlmp_noahmp
>
> COMPILE | CCPP=Y SUITES=FV3_GFS_2017_gfdlmp,FV3_GFS_2017_gfdlmp_noahmp | standard | jet.intel | fv3 |
>
>
>
> RUN | fv3_ccpp_gocart_clm | standard | | fv3 |
>
> +######################################################################################################################################################################################
>
>
> Is it possible to combine this COMPILE line with a previous one (for
> example where the original GFSv16beta suite is compiled) to avoid an extra
> compile step?
> ------------------------------
>
> In tests/rt.conf
> <#164 (comment)>
> :
>
> > @@ -166,3 +166,7 @@ COMPILE | CCPP=Y SUITES=FV3_GFS_2017_gfdlmp,FV3_GFS_2017_gfdlmp_noahmp
>
> COMPILE | CCPP=Y SUITES=FV3_GFS_2017_gfdlmp,FV3_GFS_2017_gfdlmp_noahmp | standard | jet.intel | fv3 |
>
>
>
> RUN | fv3_ccpp_gocart_clm | standard | | fv3 |
>
> +######################################################################################################################################################################################
>
>
> Also, please add this regression test to rt_gnu.conf as well.
> @junwang-noaa <https://github.com/junwang-noaa> @DusanJovic-NOAA
> <https://github.com/DusanJovic-NOAA>
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#164 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ANJBYQHL2EJ7N4OGDBNVYE3R334MTANCNFSM4OW5GIQA>
> .
>
|
|
Yes, sure.
Change it to ccpp_gfs_flake?
*Yihua----------------------------------------------------Yihua Wu, Ph D*I.M.
Systems Group
NOAA/NWS/NCEP/EMC
5830 University Research Court, Room: 2031
College Park, Maryland 20740, USA
Phone: (301)-683-3691
Fax: (301)-683-3703
…On Fri, Jul 17, 2020 at 9:53 AM Jun Wang ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/fv3_conf/ccpp_gfs_v16_flake_run.IN
<#164 (comment)>
:
> @@ -0,0 +1,28 @@
+rm -fr INPUT RESTART
I'd prefer to have this new feature separate from gfs_v16 as the feature
does not belong to gfs_v16, but based on gfs_v16. In the future it can be
one of candidate to be included in next production branch, srw, RRFS, or
gfsv17.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#164 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANJBYQAHCU6I3QZOXVEILLLR4BJW5ANCNFSM4OW5GIQA>
.
|
|
I'd suggest leaving it as is since we know it is a new feature added based
on gfs_v16.
On Fri, Jul 17, 2020 at 10:02 AM YihuaWu-NOAA <notifications@github.com>
wrote:
… Yes, sure.
Change it to ccpp_gfs_flake?
*Yihua----------------------------------------------------Yihua Wu, Ph
D*I.M.
Systems Group
NOAA/NWS/NCEP/EMC
5830 University Research Court, Room: 2031
College Park, Maryland 20740, USA
Phone: (301)-683-3691
Fax: (301)-683-3703
On Fri, Jul 17, 2020 at 9:53 AM Jun Wang ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In tests/fv3_conf/ccpp_gfs_v16_flake_run.IN
> <
#164 (comment)
>
> :
>
> > @@ -0,0 +1,28 @@
> +rm -fr INPUT RESTART
>
> I'd prefer to have this new feature separate from gfs_v16 as the feature
> does not belong to gfs_v16, but based on gfs_v16. In the future it can be
> one of candidate to be included in next production branch, srw, RRFS, or
> gfsv17.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <
#164 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ANJBYQAHCU6I3QZOXVEILLLR4BJW5ANCNFSM4OW5GIQA
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#164 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TKFMAU3II4Z2D2T4HDR4BKWRANCNFSM4OW5GIQA>
.
|
| @@ -0,0 +1,28 @@ | |||
| rm -fr INPUT RESTART | |||
Modified diag_table* to include stochastic block. Updated stochastic …
Updated NCAR ccpp physics
Added flake
Associated PRs:
NCAR/ccpp-physics#471
NOAA-EMC/ufsatm#141
#164