Skip to content

AQM bugfix with errors seen in PM2.5 and O3 outputs. Disables reigonal_atmaq_debug test#1605

Closed
BrianCurtis-NOAA wants to merge 4 commits into
ufs-community:developfrom
BrianCurtis-NOAA:bugfix2dev
Closed

AQM bugfix with errors seen in PM2.5 and O3 outputs. Disables reigonal_atmaq_debug test#1605
BrianCurtis-NOAA wants to merge 4 commits into
ufs-community:developfrom
BrianCurtis-NOAA:bugfix2dev

Conversation

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA commented Feb 9, 2023

Description

This PR brings in a bugfix from the AQM production/AQM.v7 branch that reverts code that caused an error in PM2.5 and O3 outputs

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
  • regional_atmaq baseline change
  • disable regional_atmaq_debug

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@BrianCurtis-NOAA BrianCurtis-NOAA added the Baseline Updates Current baselines will be updated. label Feb 9, 2023
@BrianCurtis-NOAA BrianCurtis-NOAA changed the title Bugfix2dev AQM bugfix with errors seen in PM2.5 and O3 outputs. Disables reigonal_atmaq_debug test Feb 9, 2023
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator Author

BrianCurtis-NOAA commented Feb 9, 2023

RegressionTests_hera.intel.log

Only regional_atmaq with expected new baselines fail.

@BrianCurtis-NOAA BrianCurtis-NOAA added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Feb 9, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 9, 2023

@BrianCurtis-NOAA please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@BrianCurtis-NOAA Is this going to be closed and a new PR made from the production branch, once #1631 is merged?

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator Author

Yes, i'll close now. Thanks

@BrianCurtis-NOAA BrianCurtis-NOAA deleted the bugfix2dev branch March 22, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants